Re: [Qemu-devel] [PATCH] memory: synchronize dirty bitmap before unmapping a range

2011-08-05 Thread Anthony Liguori
On 07/31/2011 02:47 PM, Avi Kivity wrote: When a range is being unmapped, ask accelerators (e.g. kvm) to synchronize the dirty bitmap to avoid losing information forever. Fixes grub2 screen update. Signed-off-by: Avi Kivity Applied. Thanks. Regards, Anthony Liguori --- Please apply befo

Re: [Qemu-devel] [PATCH] memory: synchronize dirty bitmap before unmapping a range

2011-08-01 Thread Avi Kivity
On 08/01/2011 01:21 PM, Jan Kiszka wrote: > > Note that drop/add is always paired (i.e. the guest never sees an > unmapped area), and we always map the full 64k even though cirrus code > manages each 32k bank individually. It looks optimal... we're probably > not testing the same thing (eith

Re: [Qemu-devel] [PATCH] memory: synchronize dirty bitmap before unmapping a range

2011-08-01 Thread Jan Kiszka
On 2011-08-01 11:45, Avi Kivity wrote: > On 08/01/2011 12:05 PM, Jan Kiszka wrote: >> On 2011-08-01 10:16, Avi Kivity wrote: >>> On 08/01/2011 10:52 AM, Jan Kiszka wrote: On 2011-08-01 09:34, Jan Kiszka wrote: > On 2011-07-31 21:47, Avi Kivity wrote: >> When a range is being

Re: [Qemu-devel] [PATCH] memory: synchronize dirty bitmap before unmapping a range

2011-08-01 Thread Avi Kivity
On 08/01/2011 12:05 PM, Jan Kiszka wrote: On 2011-08-01 10:16, Avi Kivity wrote: > On 08/01/2011 10:52 AM, Jan Kiszka wrote: >> On 2011-08-01 09:34, Jan Kiszka wrote: >> > On 2011-07-31 21:47, Avi Kivity wrote: >> >> When a range is being unmapped, ask accelerators (e.g. kvm) to >> synch

Re: [Qemu-devel] [PATCH] memory: synchronize dirty bitmap before unmapping a range

2011-08-01 Thread Avi Kivity
On 08/01/2011 12:30 PM, Avi Kivity wrote: It does not link here due to forgotten rwhandler in Makefile.target. I probably still have it in my tree, will update and re-push. done now. -- error compiling committee.c: too many arguments to function

Re: [Qemu-devel] [PATCH] memory: synchronize dirty bitmap before unmapping a range

2011-08-01 Thread Avi Kivity
On 08/01/2011 12:05 PM, Jan Kiszka wrote: On 2011-08-01 10:16, Avi Kivity wrote: > On 08/01/2011 10:52 AM, Jan Kiszka wrote: >> On 2011-08-01 09:34, Jan Kiszka wrote: >> > On 2011-07-31 21:47, Avi Kivity wrote: >> >> When a range is being unmapped, ask accelerators (e.g. kvm) to >> synch

Re: [Qemu-devel] [PATCH] memory: synchronize dirty bitmap before unmapping a range

2011-08-01 Thread Jan Kiszka
On 2011-08-01 10:16, Avi Kivity wrote: > On 08/01/2011 10:52 AM, Jan Kiszka wrote: >> On 2011-08-01 09:34, Jan Kiszka wrote: >> > On 2011-07-31 21:47, Avi Kivity wrote: >> >> When a range is being unmapped, ask accelerators (e.g. kvm) to >> synchronize the >> >> dirty bitmap to avoid losing info

Re: [Qemu-devel] [PATCH] memory: synchronize dirty bitmap before unmapping a range

2011-08-01 Thread Avi Kivity
On 08/01/2011 10:52 AM, Jan Kiszka wrote: On 2011-08-01 09:34, Jan Kiszka wrote: > On 2011-07-31 21:47, Avi Kivity wrote: >> When a range is being unmapped, ask accelerators (e.g. kvm) to synchronize the >> dirty bitmap to avoid losing information forever. >> >> Fixes grub2 screen update. >

Re: [Qemu-devel] [PATCH] memory: synchronize dirty bitmap before unmapping a range

2011-08-01 Thread Jan Kiszka
On 2011-08-01 09:34, Jan Kiszka wrote: > On 2011-07-31 21:47, Avi Kivity wrote: >> When a range is being unmapped, ask accelerators (e.g. kvm) to synchronize >> the >> dirty bitmap to avoid losing information forever. >> >> Fixes grub2 screen update. > > I does. > > But something is still broken

Re: [Qemu-devel] [PATCH] memory: synchronize dirty bitmap before unmapping a range

2011-08-01 Thread Jan Kiszka
On 2011-07-31 21:47, Avi Kivity wrote: > When a range is being unmapped, ask accelerators (e.g. kvm) to synchronize the > dirty bitmap to avoid losing information forever. > > Fixes grub2 screen update. I does. But something is still broken. As I reported before, the performance of grub2 startup

[Qemu-devel] [PATCH] memory: synchronize dirty bitmap before unmapping a range

2011-07-31 Thread Avi Kivity
When a range is being unmapped, ask accelerators (e.g. kvm) to synchronize the dirty bitmap to avoid losing information forever. Fixes grub2 screen update. Signed-off-by: Avi Kivity --- Please apply before the PCI batch to avoid bisectability issues (and don't pull, since that removes ordering)