Re: [Qemu-devel] [PATCH] memory: simple memory tree printer

2011-09-15 Thread Avi Kivity
On 09/15/2011 01:18 PM, Jan Kiszka wrote: On 2011-09-15 11:53, Avi Kivity wrote: >>>The host pci bridge remaps this as >>> 0x100105-0x100106 in the memory address space space. But >>> someone configured a cpu-local region at this address, so the cpu can't >>> reach it at all. >

Re: [Qemu-devel] [PATCH] memory: simple memory tree printer

2011-09-15 Thread Jan Kiszka
On 2011-09-15 11:53, Avi Kivity wrote: >>> The host pci bridge remaps this as >>> 0x100105-0x100106 in the memory address space space. But >>> someone configured a cpu-local region at this address, so the cpu can't >>> reach it at all. >> >> Mapping PIO into MMIO space is special as i

Re: [Qemu-devel] [PATCH] memory: simple memory tree printer

2011-09-15 Thread Avi Kivity
On 09/15/2011 12:30 PM, Jan Kiszka wrote: On 2011-09-14 21:24, Avi Kivity wrote: > On 09/14/2011 09:10 PM, Jan Kiszka wrote: >> OK, let's try again: Do we have to model hierarchy in PIO address space >> at all? I don't think so. > > > We do. A device listens to addresses 0x100-0x110. Anothe

Re: [Qemu-devel] [PATCH] memory: simple memory tree printer

2011-09-15 Thread Jan Kiszka
On 2011-09-14 21:24, Avi Kivity wrote: > On 09/14/2011 09:10 PM, Jan Kiszka wrote: >> OK, let's try again: Do we have to model hierarchy in PIO address space >> at all? I don't think so. > > > We do. A device listens to addresses 0x100-0x110. Another BAR (at > 0x106) clips this to 0x100-0x106.

Re: [Qemu-devel] [PATCH] memory: simple memory tree printer

2011-09-14 Thread Avi Kivity
On 09/14/2011 09:10 PM, Jan Kiszka wrote: OK, let's try again: Do we have to model hierarchy in PIO address space at all? I don't think so. We do. A device listens to addresses 0x100-0x110. Another BAR (at 0x106) clips this to 0x100-0x106. The pci/pci bridge clips this to 0x105-0x106. Th

Re: [Qemu-devel] [PATCH] memory: simple memory tree printer

2011-09-14 Thread Richard Henderson
On 09/14/2011 10:58 AM, Jan Kiszka wrote: >> It would also be used when we split an ISA portio region, as >> with the FDC device. There, we have 7 ports in 2 chunks. The >> offset would still be needed to convert the relative offset of >> the second chuck to be relative to the "real" un-split re

Re: [Qemu-devel] [PATCH] memory: simple memory tree printer

2011-09-14 Thread Jan Kiszka
On 2011-09-14 19:58, Jan Kiszka wrote: > On 2011-09-14 17:10, Richard Henderson wrote: >> On 09/12/2011 02:19 AM, Jan Kiszka wrote: >>> On 2011-09-12 11:11, Avi Kivity wrote: On 09/12/2011 12:01 PM, Jan Kiszka wrote: > On 2011-09-12 08:43, Richard Henderson wrote: >> On 09/11/2011 09:

Re: [Qemu-devel] [PATCH] memory: simple memory tree printer

2011-09-14 Thread Jan Kiszka
On 2011-09-14 17:10, Richard Henderson wrote: > On 09/12/2011 02:19 AM, Jan Kiszka wrote: >> On 2011-09-12 11:11, Avi Kivity wrote: >>> On 09/12/2011 12:01 PM, Jan Kiszka wrote: On 2011-09-12 08:43, Richard Henderson wrote: > On 09/11/2011 09:31 PM, Blue Swirl wrote: >> Field 'offset

Re: [Qemu-devel] [PATCH] memory: simple memory tree printer

2011-09-14 Thread Avi Kivity
On 09/14/2011 06:36 PM, Richard Henderson wrote: On 09/14/2011 08:29 AM, Avi Kivity wrote: > That's not in my queue. Which patchset was that? On the list beginning at https://lists.gnu.org/archive/html/qemu-devel/2011-08/msg02732.html to which you responded positively. It's also at g

Re: [Qemu-devel] [PATCH] memory: simple memory tree printer

2011-09-14 Thread Richard Henderson
On 09/14/2011 08:29 AM, Avi Kivity wrote: > That's not in my queue. Which patchset was that? On the list beginning at https://lists.gnu.org/archive/html/qemu-devel/2011-08/msg02732.html to which you responded positively. It's also at git://repo.or.cz/qemu/rth.git mem-api-isa r~

Re: [Qemu-devel] [PATCH] memory: simple memory tree printer

2011-09-14 Thread Avi Kivity
On 09/14/2011 06:27 PM, Richard Henderson wrote: On 09/14/2011 08:23 AM, Avi Kivity wrote: > On 09/14/2011 06:10 PM, Richard Henderson wrote: >> > >> > So the default address passed to the handler is now already relative? I >> > think we should keep it like this for all converted devices,

Re: [Qemu-devel] [PATCH] memory: simple memory tree printer

2011-09-14 Thread Richard Henderson
On 09/14/2011 08:23 AM, Avi Kivity wrote: > On 09/14/2011 06:10 PM, Richard Henderson wrote: >> > >> > So the default address passed to the handler is now already relative? I >> > think we should keep it like this for all converted devices, ie. take >> > the chance, fix the remaining models, and

Re: [Qemu-devel] [PATCH] memory: simple memory tree printer

2011-09-14 Thread Avi Kivity
On 09/14/2011 06:10 PM, Richard Henderson wrote: > > So the default address passed to the handler is now already relative? I > think we should keep it like this for all converted devices, ie. take > the chance, fix the remaining models, and drop the offset. It's non-zero for the isa portio co

Re: [Qemu-devel] [PATCH] memory: simple memory tree printer

2011-09-14 Thread Richard Henderson
On 09/12/2011 02:19 AM, Jan Kiszka wrote: > On 2011-09-12 11:11, Avi Kivity wrote: >> On 09/12/2011 12:01 PM, Jan Kiszka wrote: >>> On 2011-09-12 08:43, Richard Henderson wrote: On 09/11/2011 09:31 PM, Blue Swirl wrote: > Field 'offset' is always zero, maybe that is not interesting. Will

Re: [Qemu-devel] [PATCH] memory: simple memory tree printer

2011-09-12 Thread Blue Swirl
On Mon, Sep 12, 2011 at 10:53 AM, Avi Kivity wrote: > On 09/12/2011 01:37 PM, Gerd Hoffmann wrote: >>> >>> I/O >>> io addr off size 1 >>> -e1000-io addr c000 off size 40 >>> -piix-bmdma-container addr c040 off 0

Re: [Qemu-devel] [PATCH] memory: simple memory tree printer

2011-09-12 Thread Avi Kivity
On 09/12/2011 01:37 PM, Gerd Hoffmann wrote: I/O io addr off size 1 -e1000-io addr c000 off size 40 -piix-bmdma-container addr c040 off size 10 --bmdma addr 000c off size 4

Re: [Qemu-devel] [PATCH] memory: simple memory tree printer

2011-09-12 Thread Gerd Hoffmann
I/O io addr off size 1 -e1000-io addr c000 off size 40 -piix-bmdma-container addr c040 off size 10 --bmdma addr 000c off size 4 --piix-bmdma addr 0008 off 00

Re: [Qemu-devel] [PATCH] memory: simple memory tree printer

2011-09-12 Thread Jan Kiszka
On 2011-09-12 11:11, Avi Kivity wrote: > On 09/12/2011 12:01 PM, Jan Kiszka wrote: >> On 2011-09-12 08:43, Richard Henderson wrote: >>> On 09/11/2011 09:31 PM, Blue Swirl wrote: Field 'offset' is always zero, maybe that is not interesting. Will it become one day? >>> >>> It's not alwa

Re: [Qemu-devel] [PATCH] memory: simple memory tree printer

2011-09-12 Thread Avi Kivity
On 09/12/2011 11:53 AM, Jan Kiszka wrote: On 2011-09-12 10:46, Avi Kivity wrote: > On 09/11/2011 11:31 PM, Blue Swirl wrote: >> Add a monitor command 'info mtree' to show the memory hierarchy. >> > > Does this turn the memory hierarchy into an ABI? It shouldn't. Things > like BARs are immut

Re: [Qemu-devel] [PATCH] memory: simple memory tree printer

2011-09-12 Thread Avi Kivity
On 09/12/2011 12:01 PM, Jan Kiszka wrote: On 2011-09-12 08:43, Richard Henderson wrote: > On 09/11/2011 09:31 PM, Blue Swirl wrote: >> Field 'offset' is always zero, maybe that is not interesting. Will it >> become one day? > > It's not always zero, but only used by certain devices. I do not

Re: [Qemu-devel] [PATCH] memory: simple memory tree printer

2011-09-12 Thread Jan Kiszka
On 2011-09-12 08:43, Richard Henderson wrote: > On 09/11/2011 09:31 PM, Blue Swirl wrote: >> Field 'offset' is always zero, maybe that is not interesting. Will it >> become one day? > > It's not always zero, but only used by certain devices. I do not see any users, neither upstream nor in Avi's t

Re: [Qemu-devel] [PATCH] memory: simple memory tree printer

2011-09-12 Thread Jan Kiszka
On 2011-09-12 10:46, Avi Kivity wrote: > On 09/11/2011 11:31 PM, Blue Swirl wrote: >> Add a monitor command 'info mtree' to show the memory hierarchy. >> > > Does this turn the memory hierarchy into an ABI? It shouldn't. Things > like BARs are immutable but if a BAR is internally composed of sev

Re: [Qemu-devel] [PATCH] memory: simple memory tree printer

2011-09-12 Thread Avi Kivity
On 09/11/2011 11:31 PM, Blue Swirl wrote: Add a monitor command 'info mtree' to show the memory hierarchy. Does this turn the memory hierarchy into an ABI? It shouldn't. Things like BARs are immutable but if a BAR is internally composed of several regions, well that's no one's business.

Re: [Qemu-devel] [PATCH] memory: simple memory tree printer

2011-09-12 Thread Peter Maydell
On 11 September 2011 21:31, Blue Swirl wrote: > PPC > memory > system addr off size 7fff > -vga.chain4 addr 000a off size 1 > -macio addr 8088 off size 8 > --macio-nvram addr 0006 off size 2 > --pmac-ide addr 0002

Re: [Qemu-devel] [PATCH] memory: simple memory tree printer

2011-09-11 Thread Richard Henderson
On 09/11/2011 09:31 PM, Blue Swirl wrote: > Field 'offset' is always zero, maybe that is not interesting. Will it > become one day? It's not always zero, but only used by certain devices. r~

[Qemu-devel] [PATCH] memory: simple memory tree printer

2011-09-11 Thread Blue Swirl
Add a monitor command 'info mtree' to show the memory hierarchy. Signed-off-by: Blue Swirl --- Example output: qemu-system-i386 -monitor stdio QEMU 0.15.50 monitor - type 'help' for more information (qemu) info mtree memory system addr off size 7fff -