Re: [Qemu-devel] [PATCH] memory: give name every AddressSpace

2013-04-29 Thread Alexey Kardashevskiy
On 04/29/2013 07:25 PM, Paolo Bonzini wrote: > Il 29/04/2013 10:21, Alexey Kardashevskiy ha scritto: >> +g_free((void *)as->name); No cast here. >> ? >> >> CCppc64-softmmu/memory.o >> /home/alexey/pcipassthru/qemu-impreza/memory.c: In function >> 'address_space_destroy': >>

Re: [Qemu-devel] [PATCH] memory: give name every AddressSpace

2013-04-29 Thread David Gibson
On Mon, Apr 29, 2013 at 11:25:16AM +0200, Paolo Bonzini wrote: > Il 29/04/2013 10:21, Alexey Kardashevskiy ha scritto: > >>> >> +g_free((void *)as->name); > >> > > >> > No cast here. > > ? > > > > CCppc64-softmmu/memory.o > > /home/alexey/pcipassthru/qemu-impreza/memory.c: In function >

Re: [Qemu-devel] [PATCH] memory: give name every AddressSpace

2013-04-29 Thread Paolo Bonzini
Il 29/04/2013 10:21, Alexey Kardashevskiy ha scritto: >>> >> +g_free((void *)as->name); >> > >> > No cast here. > ? > > CCppc64-softmmu/memory.o > /home/alexey/pcipassthru/qemu-impreza/memory.c: In function > 'address_space_destroy': > /home/alexey/pcipassthru/qemu-impreza/memory.c:1626

Re: [Qemu-devel] [PATCH] memory: give name every AddressSpace

2013-04-29 Thread Alexey Kardashevskiy
On 04/29/2013 06:16 PM, Paolo Bonzini wrote: > Il 29/04/2013 04:11, Alexey Kardashevskiy ha scritto: >> The "info mtree" command in QEMU console prints only "memory" and "I/O" >> address spaces while there are actually a lot more other AddressSpace >> structs created by PCI and VIO devices. Those d

Re: [Qemu-devel] [PATCH] memory: give name every AddressSpace

2013-04-29 Thread Paolo Bonzini
Il 29/04/2013 04:11, Alexey Kardashevskiy ha scritto: > The "info mtree" command in QEMU console prints only "memory" and "I/O" > address spaces while there are actually a lot more other AddressSpace > structs created by PCI and VIO devices. Those devices do not normally > have names and therefore

[Qemu-devel] [PATCH] memory: give name every AddressSpace

2013-04-28 Thread Alexey Kardashevskiy
The "info mtree" command in QEMU console prints only "memory" and "I/O" address spaces while there are actually a lot more other AddressSpace structs created by PCI and VIO devices. Those devices do not normally have names and therefore not present in "info qtree" output. The patch fixes this. Si