Re: [Qemu-devel] [PATCH] make qemu.log name unique

2010-07-05 Thread Christophe LYON
Patches need a "Signed-off-by", and for the code review it's better to send them inline. What about patching the documentation, too? OK Here is an updated version. I have also patched the bsd and darwin ports, but couldn't actually check it is OK for lack of such platforms. I hope my mail

Re: [Qemu-devel] [PATCH] make qemu.log name unique

2010-07-01 Thread Stefan Weil
Am 01.07.2010 13:53, schrieb Christophe LYON: Maybe adding a -logfile option would allow what you're trying to achieve without affecting other use cases? I've always thought that it's strange that you can only change the logfile location in the monitor and not on the command line. Kevin Her

Re: [Qemu-devel] [PATCH] make qemu.log name unique

2010-07-01 Thread Christophe LYON
Maybe adding a -logfile option would allow what you're trying to achieve without affecting other use cases? I've always thought that it's strange that you can only change the logfile location in the monitor and not on the command line. Kevin Here is patch that does what you suggest. Christo

Re: [Qemu-devel] [PATCH] make qemu.log name unique

2010-06-29 Thread Kevin Wolf
Am 29.06.2010 10:46, schrieb Christophe LYON: > Hello, > > I propose this small patch so that the qemu log file has a unique name, > to help running several QEmu processes at once (or with different users). > > Is it OK? I don't think it's a good idea. When debugging things I usually run qemu s

[Qemu-devel] [PATCH] make qemu.log name unique

2010-06-29 Thread Christophe LYON
Hello, I propose this small patch so that the qemu log file has a unique name, to help running several QEmu processes at once (or with different users). Is it OK? Thanks Christophe. diff --git a/exec.c b/exec.c index 5969eb2..5ba8d7e 100644 --- a/exec.c +++ b/exec.c @@ -1516,7 +1516,10 @@ v