Re: [Qemu-devel] [PATCH] make: remove generated objects from target dirs

2012-03-04 Thread Michael S. Tsirkin
On Sun, Mar 04, 2012 at 05:03:14PM +0100, Andreas Färber wrote: > Am 04.03.2012 10:10, schrieb Michael S. Tsirkin: > > I ended up with qmp-commands.h in target directories, > > which makes build fail as it is found before the > > main header. > > make clean fixes it, but it might get triggered > >

Re: [Qemu-devel] [PATCH] make: remove generated objects from target dirs

2012-03-04 Thread Andreas Färber
Am 04.03.2012 10:10, schrieb Michael S. Tsirkin: > I ended up with qmp-commands.h in target directories, > which makes build fail as it is found before the > main header. > make clean fixes it, but it might get triggered > again when we make some header target-independent next. > It's easy to just

Re: [Qemu-devel] [PATCH] make: remove generated objects from target dirs

2012-03-04 Thread Michael S. Tsirkin
On Sun, Mar 04, 2012 at 01:44:26PM +, Peter Maydell wrote: > On 4 March 2012 13:31, Michael S. Tsirkin wrote: > > On Sun, Mar 04, 2012 at 01:25:59PM +, Peter Maydell wrote: > >> In general we don't have workarounds for "something > >> moved directory and this broke builds not from clean" >

Re: [Qemu-devel] [PATCH] make: remove generated objects from target dirs

2012-03-04 Thread Peter Maydell
On 4 March 2012 13:31, Michael S. Tsirkin wrote: > On Sun, Mar 04, 2012 at 01:25:59PM +, Peter Maydell wrote: >> In general we don't have workarounds for "something >> moved directory and this broke builds not from clean" > > Why don't we? It's cheaper than always doing > make clean after pull

Re: [Qemu-devel] [PATCH] make: remove generated objects from target dirs

2012-03-04 Thread Michael S. Tsirkin
On Sun, Mar 04, 2012 at 01:25:59PM +, Peter Maydell wrote: > On 4 March 2012 09:10, Michael S. Tsirkin wrote: > > I ended up with qmp-commands.h in target directories, > > which makes build fail as it is found before the > > main header. > > make clean fixes it, but it might get triggered > >

Re: [Qemu-devel] [PATCH] make: remove generated objects from target dirs

2012-03-04 Thread Peter Maydell
On 4 March 2012 09:10, Michael S. Tsirkin wrote: > I ended up with qmp-commands.h in target directories, > which makes build fail as it is found before the > main header. > make clean fixes it, but it might get triggered > again when we make some header target-independent next. > It's easy to just

[Qemu-devel] [PATCH] make: remove generated objects from target dirs

2012-03-04 Thread Michael S. Tsirkin
I ended up with qmp-commands.h in target directories, which makes build fail as it is found before the main header. make clean fixes it, but it might get triggered again when we make some header target-independent next. It's easy to just make sure all such leftovers are removed, so let's do this.