Re: [Qemu-devel] [PATCH] machine: set default kernel_cmdline in machine_initfn()

2014-05-30 Thread Markus Armbruster
Igor Mammedov writes: > On Thu, 29 May 2014 14:25:31 +0200 > Andreas Färber wrote: > >> Am 29.05.2014 14:21, schrieb Marcel Apfelbaum: >> > On Thu, 2014-05-29 at 12:47 +0200, Andreas Färber wrote: >> >> Am 29.05.2014 11:47, schrieb Igor Mammedov: >> >>> ... fixes freeing constant from vl.c by ma

Re: [Qemu-devel] [PATCH] machine: set default kernel_cmdline in machine_initfn()

2014-05-29 Thread Paolo Bonzini
Il 29/05/2014 15:26, Andreas Färber ha scritto: Am 29.05.2014 15:21, schrieb Marcel Apfelbaum: On Thu, 2014-05-29 at 15:08 +0200, Igor Mammedov wrote: On Thu, 29 May 2014 15:56:16 +0300 Marcel Apfelbaum wrote: On Thu, 2014-05-29 at 14:40 +0200, Igor Mammedov wrote: Maybe we can hack QemuOpts

Re: [Qemu-devel] [PATCH] machine: set default kernel_cmdline in machine_initfn()

2014-05-29 Thread Andreas Färber
Am 29.05.2014 15:21, schrieb Marcel Apfelbaum: > On Thu, 2014-05-29 at 15:08 +0200, Igor Mammedov wrote: >> On Thu, 29 May 2014 15:56:16 +0300 >> Marcel Apfelbaum wrote: >>> On Thu, 2014-05-29 at 14:40 +0200, Igor Mammedov wrote: Maybe we can hack QemuOpts to do s/foo_moo/foo-moo/ ? Than

Re: [Qemu-devel] [PATCH] machine: set default kernel_cmdline in machine_initfn()

2014-05-29 Thread Marcel Apfelbaum
On Thu, 2014-05-29 at 14:25 +0200, Andreas Färber wrote: > Am 29.05.2014 14:21, schrieb Marcel Apfelbaum: > > On Thu, 2014-05-29 at 12:47 +0200, Andreas Färber wrote: > >> Am 29.05.2014 11:47, schrieb Igor Mammedov: > >>> ... fixes freeing constant from vl.c by machine_finalize() > >>> > >>> Signed

Re: [Qemu-devel] [PATCH] machine: set default kernel_cmdline in machine_initfn()

2014-05-29 Thread Marcel Apfelbaum
On Thu, 2014-05-29 at 15:08 +0200, Igor Mammedov wrote: > On Thu, 29 May 2014 15:56:16 +0300 > Marcel Apfelbaum wrote: > > > On Thu, 2014-05-29 at 14:40 +0200, Igor Mammedov wrote: > > > On Thu, 29 May 2014 14:25:31 +0200 > > > Andreas Färber wrote: > > > > > > > Am 29.05.2014 14:21, schrieb Ma

Re: [Qemu-devel] [PATCH] machine: set default kernel_cmdline in machine_initfn()

2014-05-29 Thread Igor Mammedov
On Thu, 29 May 2014 15:56:16 +0300 Marcel Apfelbaum wrote: > On Thu, 2014-05-29 at 14:40 +0200, Igor Mammedov wrote: > > On Thu, 29 May 2014 14:25:31 +0200 > > Andreas Färber wrote: > > > > > Am 29.05.2014 14:21, schrieb Marcel Apfelbaum: > > > > On Thu, 2014-05-29 at 12:47 +0200, Andreas Färbe

Re: [Qemu-devel] [PATCH] machine: set default kernel_cmdline in machine_initfn()

2014-05-29 Thread Marcel Apfelbaum
On Thu, 2014-05-29 at 14:40 +0200, Igor Mammedov wrote: > On Thu, 29 May 2014 14:25:31 +0200 > Andreas Färber wrote: > > > Am 29.05.2014 14:21, schrieb Marcel Apfelbaum: > > > On Thu, 2014-05-29 at 12:47 +0200, Andreas Färber wrote: > > >> Am 29.05.2014 11:47, schrieb Igor Mammedov: > > >>> ... f

Re: [Qemu-devel] [PATCH] machine: set default kernel_cmdline in machine_initfn()

2014-05-29 Thread Igor Mammedov
On Thu, 29 May 2014 14:25:31 +0200 Andreas Färber wrote: > Am 29.05.2014 14:21, schrieb Marcel Apfelbaum: > > On Thu, 2014-05-29 at 12:47 +0200, Andreas Färber wrote: > >> Am 29.05.2014 11:47, schrieb Igor Mammedov: > >>> ... fixes freeing constant from vl.c by machine_finalize() > >>> > >>> Sign

Re: [Qemu-devel] [PATCH] machine: set default kernel_cmdline in machine_initfn()

2014-05-29 Thread Andreas Färber
Am 29.05.2014 14:21, schrieb Marcel Apfelbaum: > On Thu, 2014-05-29 at 12:47 +0200, Andreas Färber wrote: >> Am 29.05.2014 11:47, schrieb Igor Mammedov: >>> ... fixes freeing constant from vl.c by machine_finalize() >>> >>> Signed-off-by: Igor Mammedov >> >> Did you check whether there are any oth

Re: [Qemu-devel] [PATCH] machine: set default kernel_cmdline in machine_initfn()

2014-05-29 Thread Marcel Apfelbaum
On Thu, 2014-05-29 at 12:47 +0200, Andreas Färber wrote: > Am 29.05.2014 11:47, schrieb Igor Mammedov: > > ... fixes freeing constant from vl.c by machine_finalize() > > > > Signed-off-by: Igor Mammedov > > Did you check whether there are any others in need of changes? I could > imagine kernel_i

Re: [Qemu-devel] [PATCH] machine: set default kernel_cmdline in machine_initfn()

2014-05-29 Thread Igor Mammedov
On Thu, 29 May 2014 12:47:45 +0200 Andreas Färber wrote: > Am 29.05.2014 11:47, schrieb Igor Mammedov: > > ... fixes freeing constant from vl.c by machine_finalize() > > > > Signed-off-by: Igor Mammedov > > Did you check whether there are any others in need of changes? I could > imagine kernel

Re: [Qemu-devel] [PATCH] machine: set default kernel_cmdline in machine_initfn()

2014-05-29 Thread Andreas Färber
Am 29.05.2014 11:47, schrieb Igor Mammedov: > ... fixes freeing constant from vl.c by machine_finalize() > > Signed-off-by: Igor Mammedov Did you check whether there are any others in need of changes? I could imagine kernel_irqchip does, and I see that we forgot to fix the underscore in the prop

Re: [Qemu-devel] [PATCH] machine: set default kernel_cmdline in machine_initfn()

2014-05-29 Thread Marcel Apfelbaum
On Thu, 2014-05-29 at 11:47 +0200, Igor Mammedov wrote: > ... fixes freeing constant from vl.c by machine_finalize() Nice cleanup, thanks! Reviewed-by: Marcel Apfelbaum > > Signed-off-by: Igor Mammedov > --- > hw/core/machine.c |3 +++ > vl.c |7 +-- > 2 files changed

[Qemu-devel] [PATCH] machine: set default kernel_cmdline in machine_initfn()

2014-05-29 Thread Igor Mammedov
... fixes freeing constant from vl.c by machine_finalize() Signed-off-by: Igor Mammedov --- hw/core/machine.c |3 +++ vl.c |7 +-- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/hw/core/machine.c b/hw/core/machine.c index cbba679..37bd676 100644 --- a/hw/