Re: [Qemu-devel] [PATCH] machine: replace underscores in machine's property names

2014-07-18 Thread Paolo Bonzini
Il 18/07/2014 18:32, Andreas Färber ha scritto: > Am 18.07.2014 18:23, schrieb Marcel Apfelbaum: >> On Fri, 2014-07-18 at 18:10 +0200, Andreas Färber wrote: >>> Hi, >>> >>> Am 18.07.2014 17:59, schrieb Marcel Apfelbaum: On Fri, 2014-07-18 at 16:25 +0200, Andreas Färber wrote: > Am 29.06.20

Re: [Qemu-devel] [PATCH] machine: replace underscores in machine's property names

2014-07-18 Thread Marcel Apfelbaum
On Fri, 2014-07-18 at 18:32 +0200, Andreas Färber wrote: > Am 18.07.2014 18:23, schrieb Marcel Apfelbaum: > > On Fri, 2014-07-18 at 18:10 +0200, Andreas Färber wrote: > >> Hi, > >> > >> Am 18.07.2014 17:59, schrieb Marcel Apfelbaum: > >>> On Fri, 2014-07-18 at 16:25 +0200, Andreas Färber wrote: > >

Re: [Qemu-devel] [PATCH] machine: replace underscores in machine's property names

2014-07-18 Thread Andreas Färber
Am 18.07.2014 18:23, schrieb Marcel Apfelbaum: > On Fri, 2014-07-18 at 18:10 +0200, Andreas Färber wrote: >> Hi, >> >> Am 18.07.2014 17:59, schrieb Marcel Apfelbaum: >>> On Fri, 2014-07-18 at 16:25 +0200, Andreas Färber wrote: Am 29.06.2014 11:09, schrieb Marcel Apfelbaum: > Replaced '_' w

Re: [Qemu-devel] [PATCH] machine: replace underscores in machine's property names

2014-07-18 Thread Marcel Apfelbaum
On Fri, 2014-07-18 at 18:10 +0200, Andreas Färber wrote: > Hi, > > Am 18.07.2014 17:59, schrieb Marcel Apfelbaum: > > On Fri, 2014-07-18 at 16:25 +0200, Andreas Färber wrote: > >> Am 29.06.2014 11:09, schrieb Marcel Apfelbaum: > >>> Replaced '_' with '-' to comply with QOM guidelines. > >>> Made t

Re: [Qemu-devel] [PATCH] machine: replace underscores in machine's property names

2014-07-18 Thread Andreas Färber
Hi, Am 18.07.2014 17:59, schrieb Marcel Apfelbaum: > On Fri, 2014-07-18 at 16:25 +0200, Andreas Färber wrote: >> Am 29.06.2014 11:09, schrieb Marcel Apfelbaum: >>> Replaced '_' with '-' to comply with QOM guidelines. >>> Made the conversion from HMP to QMP in vl.c >>> >>> Signed-off-by: Marcel Apf

Re: [Qemu-devel] [PATCH] machine: replace underscores in machine's property names

2014-07-18 Thread Marcel Apfelbaum
On Fri, 2014-07-18 at 16:15 +0200, Andreas Färber wrote: > Am 17.07.2014 19:00, schrieb Paolo Bonzini: > > Il 17/07/2014 18:47, Michael Roth ha scritto: > >>> > My argument for getting this into 2.1 had been to avoid tools > >>> picking up > >>> > these to-be-renamed property names from the start.

Re: [Qemu-devel] [PATCH] machine: replace underscores in machine's property names

2014-07-18 Thread Marcel Apfelbaum
On Fri, 2014-07-18 at 16:25 +0200, Andreas Färber wrote: > Am 29.06.2014 11:09, schrieb Marcel Apfelbaum: > > Replaced '_' with '-' to comply with QOM guidelines. > > Made the conversion from HMP to QMP in vl.c > > > > Signed-off-by: Marcel Apfelbaum > > --- > > hw/core/machine.c | 8 >

Re: [Qemu-devel] [PATCH] machine: replace underscores in machine's property names

2014-07-18 Thread Paolo Bonzini
Il 18/07/2014 16:25, Andreas Färber ha scritto: > Actually, is this really safe? By my reading, this function handles > -object as well, which in turn allows - in theory - to instantiate any > device, where some will still have underscores in their property names. > Not sure if all non-device objec

Re: [Qemu-devel] [PATCH] machine: replace underscores in machine's property names

2014-07-18 Thread Andreas Färber
Am 29.06.2014 11:09, schrieb Marcel Apfelbaum: > Replaced '_' with '-' to comply with QOM guidelines. > Made the conversion from HMP to QMP in vl.c > > Signed-off-by: Marcel Apfelbaum > --- > hw/core/machine.c | 8 > vl.c | 12 +++- > 2 files changed, 15 insertions

Re: [Qemu-devel] [PATCH] machine: replace underscores in machine's property names

2014-07-18 Thread Paolo Bonzini
Il 18/07/2014 16:15, Andreas Färber ha scritto: > I was mainly concerned about qom-set, but same goes for qom-get. The > breakage would be in 2.2, if in 2.1 we introduce properties with foo_bar > and rename them to foo-bar in 2.2. Since they're not in 2.0, I had asked > Marcel to rename them for 2.

Re: [Qemu-devel] [PATCH] machine: replace underscores in machine's property names

2014-07-18 Thread Andreas Färber
Am 17.07.2014 19:00, schrieb Paolo Bonzini: > Il 17/07/2014 18:47, Michael Roth ha scritto: >>> > My argument for getting this into 2.1 had been to avoid tools >>> picking up >>> > these to-be-renamed property names from the start. At this point, I'm >>> > not so sure whether it's worse to break ma

Re: [Qemu-devel] [PATCH] machine: replace underscores in machine's property names

2014-07-17 Thread Marcel Apfelbaum
On Thu, 2014-07-17 at 17:55 +0100, Peter Maydell wrote: > On 29 June 2014 10:09, Marcel Apfelbaum wrote: > > Replaced '_' with '-' to comply with QOM guidelines. > > Made the conversion from HMP to QMP in vl.c > > > > Signed-off-by: Marcel Apfelbaum > > > index a1686ef..7587c97 100644 > > --- a/

Re: [Qemu-devel] [PATCH] machine: replace underscores in machine's property names

2014-07-17 Thread Paolo Bonzini
Il 17/07/2014 18:47, Michael Roth ha scritto: > My argument for getting this into 2.1 had been to avoid tools picking up > these to-be-renamed property names from the start. At this point, I'm > not so sure whether it's worse to break management tools or potentially > some rarely used/tested opti

Re: [Qemu-devel] [PATCH] machine: replace underscores in machine's property names

2014-07-17 Thread Peter Maydell
On 29 June 2014 10:09, Marcel Apfelbaum wrote: > Replaced '_' with '-' to comply with QOM guidelines. > Made the conversion from HMP to QMP in vl.c > > Signed-off-by: Marcel Apfelbaum > index a1686ef..7587c97 100644 > --- a/vl.c > +++ b/vl.c > @@ -2820,15 +2820,25 @@ static int object_set_proper

Re: [Qemu-devel] [PATCH] machine: replace underscores in machine's property names

2014-07-17 Thread Michael Roth
Quoting Andreas Färber (2014-07-17 10:48:59) > Am 17.07.2014 16:20, schrieb Paolo Bonzini: > > Il 17/07/2014 16:15, Marcel Apfelbaum ha scritto: > >> On Sun, 2014-06-29 at 14:37 +0300, Michael S. Tsirkin wrote: > >>> On Sun, Jun 29, 2014 at 12:09:15PM +0300, Marcel Apfelbaum wrote: > Replaced

Re: [Qemu-devel] [PATCH] machine: replace underscores in machine's property names

2014-07-17 Thread Andreas Färber
Am 17.07.2014 16:20, schrieb Paolo Bonzini: > Il 17/07/2014 16:15, Marcel Apfelbaum ha scritto: >> On Sun, 2014-06-29 at 14:37 +0300, Michael S. Tsirkin wrote: >>> On Sun, Jun 29, 2014 at 12:09:15PM +0300, Marcel Apfelbaum wrote: Replaced '_' with '-' to comply with QOM guidelines. Made t

Re: [Qemu-devel] [PATCH] machine: replace underscores in machine's property names

2014-07-17 Thread Paolo Bonzini
Il 17/07/2014 16:15, Marcel Apfelbaum ha scritto: On Sun, 2014-06-29 at 14:37 +0300, Michael S. Tsirkin wrote: On Sun, Jun 29, 2014 at 12:09:15PM +0300, Marcel Apfelbaum wrote: Replaced '_' with '-' to comply with QOM guidelines. Made the conversion from HMP to QMP in vl.c Signed-off-by: Marce

Re: [Qemu-devel] [PATCH] machine: replace underscores in machine's property names

2014-07-17 Thread Marcel Apfelbaum
On Sun, 2014-06-29 at 14:37 +0300, Michael S. Tsirkin wrote: > On Sun, Jun 29, 2014 at 12:09:15PM +0300, Marcel Apfelbaum wrote: > > Replaced '_' with '-' to comply with QOM guidelines. > > Made the conversion from HMP to QMP in vl.c > > > > Signed-off-by: Marcel Apfelbaum > > Nothing to do with

Re: [Qemu-devel] [PATCH] machine: replace underscores in machine's property names

2014-06-29 Thread Michael S. Tsirkin
On Sun, Jun 29, 2014 at 12:09:15PM +0300, Marcel Apfelbaum wrote: > Replaced '_' with '-' to comply with QOM guidelines. > Made the conversion from HMP to QMP in vl.c > > Signed-off-by: Marcel Apfelbaum Nothing to do with me, pls merge through Andrea's or Paolo's tree. FWIW Acked-by: Michael S.

[Qemu-devel] [PATCH] machine: replace underscores in machine's property names

2014-06-29 Thread Marcel Apfelbaum
Replaced '_' with '-' to comply with QOM guidelines. Made the conversion from HMP to QMP in vl.c Signed-off-by: Marcel Apfelbaum --- hw/core/machine.c | 8 vl.c | 12 +++- 2 files changed, 15 insertions(+), 5 deletions(-) diff --git a/hw/core/machine.c b/hw/core/m