Re: [Qemu-devel] [PATCH] m68k: implement move to/from usp register instruction

2012-09-13 Thread Greg Ungerer
Hi Richard, On 14/09/12 03:34, Richard Henderson wrote: On 09/12/2012 11:33 PM, g...@snapgear.com wrote: +uint32_t HELPER(move_from_usp)(CPUM68KState * env) +{ +return env->sp[M68K_USP]; +} You don't need helpers for these. DISAS_INSN(move_from_usp) { +TCGv reg; if (IS_USE

Re: [Qemu-devel] [PATCH] m68k: implement move to/from usp register instruction

2012-09-13 Thread Richard Henderson
On 09/12/2012 11:33 PM, g...@snapgear.com wrote: > +uint32_t HELPER(move_from_usp)(CPUM68KState * env) > +{ > +return env->sp[M68K_USP]; > +} You don't need helpers for these. > DISAS_INSN(move_from_usp) > { > +TCGv reg; > if (IS_USER(s)) { > gen_exception(s, s->pc - 2, EX

[Qemu-devel] [PATCH] m68k: implement move to/from usp register instruction

2012-09-13 Thread gerg
From: Greg Ungerer Fill out the code support for the move to/from usp instructions. They are being decoded, but there is no code to support there actions. So add it. Current versions of Linux running on the ColdFire 5208 use these instructions. Signed-off-by: Greg Ungerer --- target-m68k/help