Re: [Qemu-devel] [PATCH] lm832x: Take DeviceState pointer in lm832x_key_event()

2011-07-29 Thread Peter Maydell
On 29 July 2011 15:31, Anthony Liguori wrote: > On 07/28/2011 09:47 AM, Peter Maydell wrote: >> >> Since lm832x has been qdev'ified, its users will generally >> have a DeviceState pointer rather than an i2c_slave pointer, >> so adjust lm832x_key_event's prototype to suit. >> >> This allows the n81

Re: [Qemu-devel] [PATCH] lm832x: Take DeviceState pointer in lm832x_key_event()

2011-07-29 Thread Anthony Liguori
On 07/28/2011 09:47 AM, Peter Maydell wrote: Since lm832x has been qdev'ified, its users will generally have a DeviceState pointer rather than an i2c_slave pointer, so adjust lm832x_key_event's prototype to suit. This allows the n810 (its only user) to actually pass a correct pointer to it rathe

[Qemu-devel] [PATCH] lm832x: Take DeviceState pointer in lm832x_key_event()

2011-07-28 Thread Peter Maydell
Since lm832x has been qdev'ified, its users will generally have a DeviceState pointer rather than an i2c_slave pointer, so adjust lm832x_key_event's prototype to suit. This allows the n810 (its only user) to actually pass a correct pointer to it rather than NULL. The effect is that we no longer se