Re: [Qemu-devel] [PATCH] linux-user: fix compile failure if !CONFIG_USE_GUEST_BASE

2011-03-03 Thread Aurelien Jarno
On Thu, Feb 10, 2011 at 04:53:04PM +, Peter Maydell wrote: > If CONFIG_USE_GUEST_BASE is not defined, gcc complains: > linux-user/mmap.c:235: error: comparison of unsigned expression >= 0 is > always true > > because RESERVED_VA is #defined to 0. Since mmap_find_vma_reserved() > will never b

Re: [Qemu-devel] [PATCH] linux-user: fix compile failure if !CONFIG_USE_GUEST_BASE

2011-02-21 Thread Peter Maydell
Ping? On 10 February 2011 16:53, Peter Maydell wrote: > If CONFIG_USE_GUEST_BASE is not defined, gcc complains: >  linux-user/mmap.c:235: error: comparison of unsigned expression >= 0 is > always true > > because RESERVED_VA is #defined to 0. Since mmap_find_vma_reserved() > will never be called

[Qemu-devel] [PATCH] linux-user: fix compile failure if !CONFIG_USE_GUEST_BASE

2011-02-10 Thread Peter Maydell
If CONFIG_USE_GUEST_BASE is not defined, gcc complains: linux-user/mmap.c:235: error: comparison of unsigned expression >= 0 is always true because RESERVED_VA is #defined to 0. Since mmap_find_vma_reserved() will never be called anyway if RESERVED_VA is always 0, fix this by simply #ifdef'ing a