Re: [Qemu-devel] [PATCH] linux-user: fix cmsg conversion in case of multiple headers

2015-09-28 Thread Jonathan Neuschäfer
On Mon, Sep 28, 2015 at 04:38:03PM +0300, Riku Voipio wrote: > Applied to linux-user tree, thanks. Thanks. > For next time, use three dashes "---" to separate version-to-version > change descriptions from commit messages. This way git will > automatically leave them out when doing git am. Ok, I'

Re: [Qemu-devel] [PATCH] linux-user: fix cmsg conversion in case of multiple headers

2015-09-28 Thread Riku Voipio
Hi, On Thu, Sep 03, 2015 at 07:27:26AM +0200, Jonathan Neuschäfer wrote: > Currently, __target_cmsg_nxthdr compares a pointer derived from > target_cmsg against the msg_control field of target_msgh (through > subtraction). This failed for me when emulating i386 code under x86_64, > because pointe

Re: [Qemu-devel] [PATCH] linux-user: fix cmsg conversion in case of multiple headers

2015-09-21 Thread Jonathan Neuschäfer
On Mon, Sep 21, 2015 at 12:45:21PM -0700, Riku Voipio wrote: > On Mon, Sep 21, 2015 at 06:13:57AM -0700, Peter Maydell wrote: > > On 20 September 2015 at 22:34, Jonathan Neuschäfer [...] > > > What's the status of this patch? > > > It's waiting for Riku to wake up and put it into a linux-user > >

Re: [Qemu-devel] [PATCH] linux-user: fix cmsg conversion in case of multiple headers

2015-09-21 Thread Riku Voipio
On Mon, Sep 21, 2015 at 06:13:57AM -0700, Peter Maydell wrote: > On 20 September 2015 at 22:34, Jonathan Neuschäfer > wrote: > > On Fri, Sep 04, 2015 at 01:48:39PM +0100, Peter Maydell wrote: > >> On 3 September 2015 at 06:27, Jonathan Neuschäfer > >> wrote: > >> > Currently, __target_cmsg_nxthd

Re: [Qemu-devel] [PATCH] linux-user: fix cmsg conversion in case of multiple headers

2015-09-21 Thread Peter Maydell
On 20 September 2015 at 22:34, Jonathan Neuschäfer wrote: > On Fri, Sep 04, 2015 at 01:48:39PM +0100, Peter Maydell wrote: >> On 3 September 2015 at 06:27, Jonathan Neuschäfer >> wrote: >> > Currently, __target_cmsg_nxthdr compares a pointer derived from >> > target_cmsg against the msg_control

Re: [Qemu-devel] [PATCH] linux-user: fix cmsg conversion in case of multiple headers

2015-09-20 Thread Jonathan Neuschäfer
On Fri, Sep 04, 2015 at 01:48:39PM +0100, Peter Maydell wrote: > On 3 September 2015 at 06:27, Jonathan Neuschäfer > wrote: > > Currently, __target_cmsg_nxthdr compares a pointer derived from > > target_cmsg against the msg_control field of target_msgh (through > > subtraction). This failed for

Re: [Qemu-devel] [PATCH] linux-user: fix cmsg conversion in case of multiple headers

2015-09-04 Thread Peter Maydell
On 3 September 2015 at 06:27, Jonathan Neuschäfer wrote: > Currently, __target_cmsg_nxthdr compares a pointer derived from > target_cmsg against the msg_control field of target_msgh (through > subtraction). This failed for me when emulating i386 code under x86_64, > because pointers in the host a

[Qemu-devel] [PATCH] linux-user: fix cmsg conversion in case of multiple headers

2015-09-02 Thread Jonathan Neuschäfer
Currently, __target_cmsg_nxthdr compares a pointer derived from target_cmsg against the msg_control field of target_msgh (through subtraction). This failed for me when emulating i386 code under x86_64, because pointers in the host address space and pointers in the guest address space were not the

Re: [Qemu-devel] [PATCH] linux-user: fix cmsg conversion in case of multiple headers

2015-09-01 Thread Jonathan Neuschäfer
On Tue, Sep 01, 2015 at 04:45:12PM +0100, Peter Maydell wrote: > Code-wise this looks good; thanks. There are a few minor style > nits caught by scripts/checkpatch.pl, which it would be nice if > you can fix. (They're mostly things that were present in the code > already, but we like to fix the sty

Re: [Qemu-devel] [PATCH] linux-user: fix cmsg conversion in case of multiple headers

2015-09-01 Thread Peter Maydell
On 31 August 2015 at 20:27, Jonathan Neuschäfer wrote: > Currently, __target_cmsg_nxthdr compares a pointer derived from > target_cmsg against the msg_control field of target_msgh (through > subtraction). This failed for me when emulating i386 code under x86_64, > because pointers in the host add

[Qemu-devel] [PATCH] linux-user: fix cmsg conversion in case of multiple headers

2015-08-31 Thread Jonathan Neuschäfer
Currently, __target_cmsg_nxthdr compares a pointer derived from target_cmsg against the msg_control field of target_msgh (through subtraction). This failed for me when emulating i386 code under x86_64, because pointers in the host address space and pointers in the guest address space were not the