Re: [Qemu-devel] [PATCH] linux-user: Fix indirect syscall handling for MIPS

2011-08-05 Thread Peter Maydell
On 5 August 2011 01:05, An-Cheng Huang wrote: > Ok the following patch changes the number of arguments for sys_syscall > to 8 in mips_syscall_args and also skips the do_syscall() call if any > of the get_user() calls fails. Do you think combining these makes sense > or should they be two separate

Re: [Qemu-devel] [PATCH] linux-user: Fix indirect syscall handling for MIPS

2011-08-04 Thread An-Cheng Huang
On Thu, Aug 04, 2011 at 11:43:31PM +0100, Peter Maydell wrote: > On 4 August 2011 23:16, An-Cheng Huang wrote: > > A simpler approach would be to just change the number of arguments for > > sys_syscall to 8 in the mips_syscall_args table so that for indirect > > syscalls the "higher" arguments are

Re: [Qemu-devel] [PATCH] linux-user: Fix indirect syscall handling for MIPS

2011-08-04 Thread Peter Maydell
On 4 August 2011 23:16, An-Cheng Huang wrote: > I ran into the problem of indirect syscalls not working with > mips-linux-user and found that the number of arguments for sys_syscall > is 0 in the mips_syscall_args table, which means the "higher" arguments > (5, 6, 7, and 8) are never obtained from

[Qemu-devel] [PATCH] linux-user: Fix indirect syscall handling for MIPS

2011-08-04 Thread An-Cheng Huang
I ran into the problem of indirect syscalls not working with mips-linux-user and found that the number of arguments for sys_syscall is 0 in the mips_syscall_args table, which means the "higher" arguments (5, 6, 7, and 8) are never obtained from the stack for the do_syscall() invocation for indir