Re: [Qemu-devel] [PATCH] linux-user/ppc: Implement swapcontext syscall

2018-07-22 Thread Laurent Vivier
Le 18/07/2018 à 22:06, Richard Henderson a écrit : > This allows the tests generated by debian-powerpc-user-cross > to function properly, especially tests/test-coroutine. > > Technically this syscall is available to both ppc32 and ppc64, > but only ppc32 glibc actually uses it. Thus the ppc64 pat

Re: [Qemu-devel] [PATCH] linux-user/ppc: Implement swapcontext syscall

2018-07-19 Thread Philippe Mathieu-Daudé
On 07/19/2018 08:13 AM, Richard Henderson wrote: > On 07/18/2018 03:56 PM, Philippe Mathieu-Daudé wrote: >>> + >>> +/* This syscall implements {get,set,swap}context for userland. */ >> >> This comment confuses me because do_setcontext() is available at line 625. > > But that's not wired up as a s

Re: [Qemu-devel] [PATCH] linux-user/ppc: Implement swapcontext syscall

2018-07-19 Thread Peter Maydell
On 19 July 2018 at 16:24, Richard Henderson wrote: > On 07/19/2018 06:05 AM, Alex Bennée wrote: >> I'm confused by the lock_user_struct/unlock_user_struct which AFAICT are >> basically access checks. Is there an implied locking I'm missing? > > I have no idea why those have that name. There's no

Re: [Qemu-devel] [PATCH] linux-user/ppc: Implement swapcontext syscall

2018-07-19 Thread Richard Henderson
On 07/19/2018 06:05 AM, Alex Bennée wrote: > I'm confused by the lock_user_struct/unlock_user_struct which AFAICT are > basically access checks. Is there an implied locking I'm missing? I have no idea why those have that name. There's no lock, just a validation of the underlying pages and a trans

Re: [Qemu-devel] [PATCH] linux-user/ppc: Implement swapcontext syscall

2018-07-19 Thread Alex Bennée
Richard Henderson writes: > This allows the tests generated by debian-powerpc-user-cross > to function properly, especially tests/test-coroutine. > > Technically this syscall is available to both ppc32 and ppc64, > but only ppc32 glibc actually uses it. Thus the ppc64 path is > untested. > > S

Re: [Qemu-devel] [PATCH] linux-user/ppc: Implement swapcontext syscall

2018-07-19 Thread Richard Henderson
On 07/18/2018 03:56 PM, Philippe Mathieu-Daudé wrote: >> + >> +/* This syscall implements {get,set,swap}context for userland. */ > > This comment confuses me because do_setcontext() is available at line 625. But that's not wired up as a syscall. >> +/* For ppc32, ctx_size is "reserved for f

Re: [Qemu-devel] [PATCH] linux-user/ppc: Implement swapcontext syscall

2018-07-18 Thread Philippe Mathieu-Daudé
Hi Richard, On 07/18/2018 05:06 PM, Richard Henderson wrote: > This allows the tests generated by debian-powerpc-user-cross > to function properly, especially tests/test-coroutine. > > Technically this syscall is available to both ppc32 and ppc64, > but only ppc32 glibc actually uses it. Thus th

[Qemu-devel] [PATCH] linux-user/ppc: Implement swapcontext syscall

2018-07-18 Thread Richard Henderson
This allows the tests generated by debian-powerpc-user-cross to function properly, especially tests/test-coroutine. Technically this syscall is available to both ppc32 and ppc64, but only ppc32 glibc actually uses it. Thus the ppc64 path is untested. Signed-off-by: Richard Henderson --- linux-