Re: [Qemu-devel] [PATCH] libvixl: Correct ordering of includes and fix NetBSD build

2017-05-15 Thread Kamil Rytarowski
On 15.05.2017 15:57, Eric Blake wrote: > On 05/13/2017 05:04 PM, Philippe Mathieu-Daudé wrote: >> Hi Kamil, >> >> I think it is safer to add it in disas/libvixl/Makefile.objs where >> QEMU_CFLAGS are tuned for libvixl. >> This way you don't need to modify upstream libvixl. >> > > Ah, right. disas/

Re: [Qemu-devel] [PATCH] libvixl: Correct ordering of includes and fix NetBSD build

2017-05-15 Thread Eric Blake
On 05/13/2017 05:04 PM, Philippe Mathieu-Daudé wrote: > Hi Kamil, > > I think it is safer to add it in disas/libvixl/Makefile.objs where > QEMU_CFLAGS are tuned for libvixl. > This way you don't need to modify upstream libvixl. > Ah, right. disas/libvixl is one of the directories exempt from our

Re: [Qemu-devel] [PATCH] libvixl: Correct ordering of includes and fix NetBSD build

2017-05-13 Thread Kamil Rytarowski
Hello, I will give it a try and submit as a new patch. On 14.05.2017 00:04, Philippe Mathieu-Daudé wrote: > Hi Kamil, > > I think it is safer to add it in disas/libvixl/Makefile.objs where > QEMU_CFLAGS are tuned for libvixl. > This way you don't need to modify upstream libvixl. > > Regards, >

Re: [Qemu-devel] [PATCH] libvixl: Correct ordering of includes and fix NetBSD build

2017-05-13 Thread Philippe Mathieu-Daudé
Hi Kamil, I think it is safer to add it in disas/libvixl/Makefile.objs where QEMU_CFLAGS are tuned for libvixl. This way you don't need to modify upstream libvixl. Regards, Phil. On 05/12/2017 10:54 PM, Kamil Rytarowski wrote: The __STDC_CONSTANT_MACROS symbol must be defined before includi

[Qemu-devel] [PATCH] libvixl: Correct ordering of includes and fix NetBSD build

2017-05-12 Thread Kamil Rytarowski
The __STDC_CONSTANT_MACROS symbol must be defined before including directly or indirectly in order to get support for macros for integer constants like INT8_C(). The vixl/globals.h headers defines __STDC_CONSTANT_MACROS and must be included before other system headers. This change fixes build fa