Re: [Qemu-devel] [PATCH] libvhost-user: handle NOFD flag in call/kick/err better

2019-09-20 Thread Stefan Hajnoczi
On Wed, Sep 18, 2019 at 11:49:14AM +0200, Johannes Berg wrote: > On Wed, 2019-09-18 at 10:39 +0100, Stefan Hajnoczi wrote: > > > > > vu_check_queue_msg_file(VuDev *dev, VhostUserMsg *vmsg) > > > { > > > int index = vmsg->payload.u64 & VHOST_USER_VRING_IDX_MASK; > > > +bool nofd = vmsg->

Re: [Qemu-devel] [PATCH] libvhost-user: handle NOFD flag in call/kick/err better

2019-09-18 Thread Johannes Berg
On Wed, 2019-09-18 at 10:39 +0100, Stefan Hajnoczi wrote: > > > vu_check_queue_msg_file(VuDev *dev, VhostUserMsg *vmsg) > > { > > int index = vmsg->payload.u64 & VHOST_USER_VRING_IDX_MASK; > > +bool nofd = vmsg->payload.u64 & VHOST_USER_VRING_NOFD_MASK; > > > > if (index >= dev->

Re: [Qemu-devel] [PATCH] libvhost-user: handle NOFD flag in call/kick/err better

2019-09-18 Thread Stefan Hajnoczi
On Tue, Sep 17, 2019 at 02:25:59PM +0200, Johannes Berg wrote: > diff --git a/contrib/libvhost-user/libvhost-user.c > b/contrib/libvhost-user/libvhost-user.c > index f1677da21201..17b7833d1f6b 100644 > --- a/contrib/libvhost-user/libvhost-user.c > +++ b/contrib/libvhost-user/libvhost-user.c > @@ -

Re: [Qemu-devel] [PATCH] libvhost-user: handle NOFD flag in call/kick/err better

2019-09-17 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190917122559.1-1-johan...@sipsolutions.net/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEG

Re: [Qemu-devel] [PATCH] libvhost-user: handle NOFD flag in call/kick/err better

2019-09-17 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190917122559.1-1-johan...@sipsolutions.net/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/ba

[Qemu-devel] [PATCH] libvhost-user: handle NOFD flag in call/kick/err better

2019-09-17 Thread Johannes Berg
From: Johannes Berg The code here is odd, for example will it print out invalid file descriptor numbers that were never sent in the message. Clean that up a bit so it's actually possible to implement a device that uses polling. Signed-off-by: Johannes Berg --- contrib/libvhost-user/libvhost-u