Re: [Qemu-devel] [PATCH] libcacard: remove useless initializers

2014-05-12 Thread Markus Armbruster
Michael Tokarev writes: > 11.05.2014 11:58, Alon Levy wrote: >> On 05/08/2014 08:19 PM, Michael Tokarev wrote: >>> libcacard has many functions which initializes local variables >>> at declaration time, which are always assigned some values later >>> (often right after declaration). Clean up the

Re: [Qemu-devel] [PATCH] libcacard: remove useless initializers

2014-05-11 Thread Michael Tokarev
11.05.2014 11:58, Alon Levy wrote: > On 05/08/2014 08:19 PM, Michael Tokarev wrote: >> libcacard has many functions which initializes local variables >> at declaration time, which are always assigned some values later >> (often right after declaration). Clean up these initializers. > > How is thi

Re: [Qemu-devel] [PATCH] libcacard: remove useless initializers

2014-05-11 Thread Alon Levy
On 05/08/2014 08:19 PM, Michael Tokarev wrote: > libcacard has many functions which initializes local variables > at declaration time, which are always assigned some values later > (often right after declaration). Clean up these initializers. How is this an improvement? Doesn't the compiler ignor

[Qemu-devel] [PATCH] libcacard: remove useless initializers

2014-05-08 Thread Michael Tokarev
libcacard has many functions which initializes local variables at declaration time, which are always assigned some values later (often right after declaration). Clean up these initializers. Signed-off-by: Michael Tokarev --- libcacard/cac.c| 14 +++--- libcacard/card_7816.