Re: [Qemu-devel] [PATCH] libcacard: fix wrong array expansion logic

2014-05-25 Thread Michael Tokarev
26.05.2014 10:25, Markus Armbruster wrote: > Michael Tokarev writes: > >> The currrent code in libcacard/vcard_emul_nss.c:vcard_emul_options() >> has a weird bug in variable usage around expanding opts->vreader >> array. >> >> There's a helper variable, vreaderOpt, which is first needlessly >> in

Re: [Qemu-devel] [PATCH] libcacard: fix wrong array expansion logic

2014-05-25 Thread Markus Armbruster
Michael Tokarev writes: > The currrent code in libcacard/vcard_emul_nss.c:vcard_emul_options() > has a weird bug in variable usage around expanding opts->vreader > array. > > There's a helper variable, vreaderOpt, which is first needlessly > initialized to NULL, next, conditionally, only we have

[Qemu-devel] [PATCH] libcacard: fix wrong array expansion logic

2014-05-23 Thread Michael Tokarev
The currrent code in libcacard/vcard_emul_nss.c:vcard_emul_options() has a weird bug in variable usage around expanding opts->vreader array. There's a helper variable, vreaderOpt, which is first needlessly initialized to NULL, next, conditionally, only we have to expand opts->vreader, receives arr