Re: [Qemu-devel] [PATCH] libcacard: actually use the symbols file

2014-04-27 Thread Michael Tokarev
27.04.2014 18:14, Paolo Bonzini wrote: > Il 27/04/2014 15:53, Michael Tokarev ha scritto: >> So, what do we do here? Should we actually enable proper exporting? > > Yes, definitely. If you don't want libqemuutil/libqemustub, you can rewrite > things to use GLib instead of the handful of libqemu

Re: [Qemu-devel] [PATCH] libcacard: actually use the symbols file

2014-04-27 Thread Paolo Bonzini
Il 27/04/2014 15:53, Michael Tokarev ha scritto: So, what do we do here? Should we actually enable proper exporting? Yes, definitely. If you don't want libqemuutil/libqemustub, you can rewrite things to use GLib instead of the handful of libqemuutil symbols that vscclient actually needs.

Re: [Qemu-devel] [PATCH] libcacard: actually use the symbols file

2014-04-27 Thread Michael Tokarev
27.04.2014 17:35, Paolo Bonzini пишет: > > > - Messaggio originale - >> Da: "Michael Tokarev" >> A: "Paolo Bonzini" , "Alon Levy" >> Cc: qemu-devel@nongnu.org >> Inviato: Domenica, 27 aprile 2014 14:59:45 >> Ogget

Re: [Qemu-devel] [PATCH] libcacard: actually use the symbols file

2014-04-27 Thread Paolo Bonzini
- Messaggio originale - > Da: "Michael Tokarev" > A: "Paolo Bonzini" , "Alon Levy" > Cc: qemu-devel@nongnu.org > Inviato: Domenica, 27 aprile 2014 14:59:45 > Oggetto: Re: [Qemu-devel] [PATCH] libcacard: actually use the symbols file > &g

Re: [Qemu-devel] [PATCH] libcacard: actually use the symbols file

2014-04-27 Thread Michael Tokarev
27.04.2014 13:54, Paolo Bonzini wrote: > Il 27/04/2014 10:10, Michael Tokarev ha scritto: [] >> Well. vscclient explicitly uses them in the code, but only links with >> libcacard, not with other qemu objects. So adding proper qemu objects >> here should be fine. I can take care of that. >> >> O

Re: [Qemu-devel] [PATCH] libcacard: actually use the symbols file

2014-04-27 Thread Paolo Bonzini
Il 27/04/2014 10:10, Michael Tokarev ha scritto: >> qemu_mutex_lock >> qemu_mutex_unlock >> qemu_cond_wait >> qemu_cond_signal >> qemu_thread_create >> socket_init >> qemu_socket >> qemu_mutex_init >> qemu_cond_init >> >> So it looks like a preparation patch is needed before this one, to >> ensur

Re: [Qemu-devel] [PATCH] libcacard: actually use the symbols file

2014-04-27 Thread Michael Tokarev
27.04.2014 12:05, Alon Levy wrote: > On 04/21/2014 12:09 PM, Michael Tokarev wrote: >> 21.04.2014 13:01, Michael Tokarev wrote: >>> libtool has an argument for .syms file, which is -export-symbols. >>> There's no argument `-export-syms', and it looks like at least on >>> linux, -export-syms is just

Re: [Qemu-devel] [PATCH] libcacard: actually use the symbols file

2014-04-27 Thread Alon Levy
On 04/21/2014 12:09 PM, Michael Tokarev wrote: > 21.04.2014 13:01, Michael Tokarev wrote: >> libtool has an argument for .syms file, which is -export-symbols. >> There's no argument `-export-syms', and it looks like at least on >> linux, -export-syms is just ignored. Use the correct argument, >> -

Re: [Qemu-devel] [PATCH] libcacard: actually use the symbols file

2014-04-21 Thread Michael Tokarev
21.04.2014 13:01, Michael Tokarev wrote: > libtool has an argument for .syms file, which is -export-symbols. > There's no argument `-export-syms', and it looks like at least on > linux, -export-syms is just ignored. Use the correct argument, > -export-symbols, to actually get the right export list

[Qemu-devel] [PATCH] libcacard: actually use the symbols file

2014-04-21 Thread Michael Tokarev
libtool has an argument for .syms file, which is -export-symbols. There's no argument `-export-syms', and it looks like at least on linux, -export-syms is just ignored. Use the correct argument, -export-symbols, to actually get the right export list. Signed-off-by: Michael Tokarev --- libcacard