Re: [Qemu-devel] [PATCH] libcacard: Fix compilation with gcc-4.7

2012-03-09 Thread Anthony Liguori
On 03/02/2012 09:49 AM, Hans de Goede wrote: VCARD_ATR_PREFIX is used as part of an array initializer so it should not have () around it, so far this happened to work, but gcc-4.7 does not like it. Signed-off-by: Hans de Goede Applied. Thanks. Regards, Anthony Liguori --- libcacard/vcar

Re: [Qemu-devel] [PATCH] libcacard: Fix compilation with gcc-4.7

2012-03-06 Thread Alon Levy
On Fri, Mar 02, 2012 at 04:49:44PM +0100, Hans de Goede wrote: Ack. Anthony, this breaks build for libcacard, caused by my last commit to the same file as Brad noted: commit 0082f4336e128a17d5f34e01de0fd29930e99b0d Author: Alon Levy Date: Sun Feb 26 17:09:24 2012 +0100 lib

Re: [Qemu-devel] [PATCH] libcacard: Fix compilation with gcc-4.7

2012-03-05 Thread Michal Privoznik
On 02.03.2012 16:49, Hans de Goede wrote: > VCARD_ATR_PREFIX is used as part of an array initializer so it should > not have () around it, so far this happened to work, but gcc-4.7 does > not like it. Neither do gcc-4.6.2.

Re: [Qemu-devel] [PATCH] libcacard: Fix compilation with gcc-4.7

2012-03-05 Thread Alon Levy
On Mon, Mar 05, 2012 at 02:47:13PM +0200, Alon Levy wrote: > On Fri, Mar 02, 2012 at 08:44:09PM -0500, Brad Smith wrote: > > On 02/03/12 10:49 AM, Hans de Goede wrote: > > >VCARD_ATR_PREFIX is used as part of an array initializer so it should > > >not have () around it, so far this happened to work

Re: [Qemu-devel] [PATCH] libcacard: Fix compilation with gcc-4.7

2012-03-05 Thread Alon Levy
On Fri, Mar 02, 2012 at 08:44:09PM -0500, Brad Smith wrote: > On 02/03/12 10:49 AM, Hans de Goede wrote: > >VCARD_ATR_PREFIX is used as part of an array initializer so it should > >not have () around it, so far this happened to work, but gcc-4.7 does > >not like it. > Thanks for the report, my ba

Re: [Qemu-devel] [PATCH] libcacard: Fix compilation with gcc-4.7

2012-03-02 Thread Brad Smith
On 02/03/12 10:49 AM, Hans de Goede wrote: VCARD_ATR_PREFIX is used as part of an array initializer so it should not have () around it, so far this happened to work, but gcc-4.7 does not like it. This recent commit.. libcacard: fix reported ATR length Broke the build on my OpenBSD (gcc 4.2.1)

[Qemu-devel] [PATCH] libcacard: Fix compilation with gcc-4.7

2012-03-02 Thread Hans de Goede
VCARD_ATR_PREFIX is used as part of an array initializer so it should not have () around it, so far this happened to work, but gcc-4.7 does not like it. Signed-off-by: Hans de Goede --- libcacard/vcardt.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libcacard/vcard