Re: [Qemu-devel] [PATCH] kvmclock: clock should count only if vm is running (v2)

2013-07-01 Thread Gleb Natapov
On Mon, Jul 01, 2013 at 01:44:42PM +0200, Paolo Bonzini wrote: > Il 25/06/2013 14:18, Gleb Natapov ha scritto: > > On Tue, Jun 18, 2013 at 08:38:25PM -0300, Marcelo Tosatti wrote: > >> > > >> > v2: remove unnecessary runstate_is_running() usage (Paolo) > >> > > >> > -- > >> > > >> > kvmclock sho

Re: [Qemu-devel] [PATCH] kvmclock: clock should count only if vm is running (v2)

2013-07-01 Thread Paolo Bonzini
Il 25/06/2013 14:18, Gleb Natapov ha scritto: > On Tue, Jun 18, 2013 at 08:38:25PM -0300, Marcelo Tosatti wrote: >> > >> > v2: remove unnecessary runstate_is_running() usage (Paolo) >> > >> > -- >> > >> > kvmclock should not count while vm is paused, because: >> > >> > 1) if the vm is paused fo

Re: [Qemu-devel] [PATCH] kvmclock: clock should count only if vm is running (v2)

2013-06-25 Thread Gleb Natapov
On Tue, Jun 18, 2013 at 08:38:25PM -0300, Marcelo Tosatti wrote: > > v2: remove unnecessary runstate_is_running() usage (Paolo) > > -- > > kvmclock should not count while vm is paused, because: > > 1) if the vm is paused for long periods, timekeeping > math can overflow while converting the (la

Re: [Qemu-devel] [PATCH] kvmclock: clock should count only if vm is running

2013-06-18 Thread Marcelo Tosatti
On Tue, Jun 18, 2013 at 11:02:27AM +0200, Paolo Bonzini wrote: > Hi Marcelo, sorry for the late review. > > Il 08/06/2013 04:00, Marcelo Tosatti ha scritto: > > kvmclock should not count while vm is paused, because: > > > > 1) if the vm is paused for long periods, timekeeping > > math can overfl

[Qemu-devel] [PATCH] kvmclock: clock should count only if vm is running (v2)

2013-06-18 Thread Marcelo Tosatti
v2: remove unnecessary runstate_is_running() usage (Paolo) -- kvmclock should not count while vm is paused, because: 1) if the vm is paused for long periods, timekeeping math can overflow while converting the (large) clocksource delta to nanoseconds. 2) Users rely on CLOCK_MONOTONIC to count r

Re: [Qemu-devel] [PATCH] kvmclock: clock should count only if vm is running

2013-06-18 Thread Paolo Bonzini
Hi Marcelo, sorry for the late review. Il 08/06/2013 04:00, Marcelo Tosatti ha scritto: > kvmclock should not count while vm is paused, because: > > 1) if the vm is paused for long periods, timekeeping > math can overflow while converting the (large) clocksource > delta to nanoseconds. > > 2)

[Qemu-devel] [PATCH] kvmclock: clock should count only if vm is running

2013-06-07 Thread Marcelo Tosatti
kvmclock should not count while vm is paused, because: 1) if the vm is paused for long periods, timekeeping math can overflow while converting the (large) clocksource delta to nanoseconds. 2) Users rely on CLOCK_MONOTONIC to count run time, that is, time which OS has been in a runnable state