Re: [Qemu-devel] [PATCH] kvmclock: clarify usage of cpu_clean_all_dirty

2014-09-16 Thread Marcelo Tosatti
On Tue, Sep 16, 2014 at 06:22:15PM +0200, Paolo Bonzini wrote: > Il 16/09/2014 18:07, Marcelo Tosatti ha scritto: > >> > The cpu_synchronize_all_states() call in kvmclock_vm_state_change() is > >> > needed to make env->tsc up to date with the value on the source, right? > > Its there to make sure t

Re: [Qemu-devel] [PATCH] kvmclock: clarify usage of cpu_clean_all_dirty

2014-09-16 Thread Marcelo Tosatti
On Tue, Sep 16, 2014 at 05:42:16PM +0200, Paolo Bonzini wrote: > Il 16/09/2014 17:14, Marcelo Tosatti ha scritto: > > + /* > > +* Make sure that CPU state is synchronized from KVM > > +* once every VM state change callback has finished. > > Which other callback could affect the in-kernel

Re: [Qemu-devel] [PATCH] kvmclock: clarify usage of cpu_clean_all_dirty

2014-09-16 Thread Marcelo Tosatti
On Tue, Sep 16, 2014 at 01:48:24PM -0300, Marcelo Tosatti wrote: > On Tue, Sep 16, 2014 at 06:22:15PM +0200, Paolo Bonzini wrote: > > Il 16/09/2014 18:07, Marcelo Tosatti ha scritto: > > >> > The cpu_synchronize_all_states() call in kvmclock_vm_state_change() is > > >> > needed to make env->tsc up

Re: [Qemu-devel] [PATCH] kvmclock: clarify usage of cpu_clean_all_dirty

2014-09-16 Thread Marcelo Tosatti
On Tue, Sep 16, 2014 at 06:22:15PM +0200, Paolo Bonzini wrote: > Il 16/09/2014 18:07, Marcelo Tosatti ha scritto: > >> > The cpu_synchronize_all_states() call in kvmclock_vm_state_change() is > >> > needed to make env->tsc up to date with the value on the source, right? > > Its there to make sure t

Re: [Qemu-devel] [PATCH] kvmclock: clarify usage of cpu_clean_all_dirty

2014-09-16 Thread Paolo Bonzini
Il 16/09/2014 18:07, Marcelo Tosatti ha scritto: >> > The cpu_synchronize_all_states() call in kvmclock_vm_state_change() is >> > needed to make env->tsc up to date with the value on the source, right? > Its there to make sure the pair > > env->tsc, s->clock = data.clock > > are relative to point

Re: [Qemu-devel] [PATCH] kvmclock: clarify usage of cpu_clean_all_dirty

2014-09-16 Thread Marcelo Tosatti
On Tue, Sep 16, 2014 at 06:03:40PM +0200, Paolo Bonzini wrote: > Il 16/09/2014 17:55, Marcelo Tosatti ha scritto: > > On Tue, Sep 16, 2014 at 05:42:16PM +0200, Paolo Bonzini wrote: > >> Il 16/09/2014 17:14, Marcelo Tosatti ha scritto: > >>> + /* > >>> + * Make sure that CPU state is synchronized f

Re: [Qemu-devel] [PATCH] kvmclock: clarify usage of cpu_clean_all_dirty

2014-09-16 Thread Paolo Bonzini
Il 16/09/2014 17:55, Marcelo Tosatti ha scritto: > On Tue, Sep 16, 2014 at 05:42:16PM +0200, Paolo Bonzini wrote: >> Il 16/09/2014 17:14, Marcelo Tosatti ha scritto: >>> + /* >>> +* Make sure that CPU state is synchronized from KVM >>> +* once every VM state change callback has finished.

Re: [Qemu-devel] [PATCH] kvmclock: clarify usage of cpu_clean_all_dirty

2014-09-16 Thread Marcelo Tosatti
On Tue, Sep 16, 2014 at 05:42:16PM +0200, Paolo Bonzini wrote: > Il 16/09/2014 17:14, Marcelo Tosatti ha scritto: > > + /* > > +* Make sure that CPU state is synchronized from KVM > > +* once every VM state change callback has finished. > > Which other callback could affect the in-kernel

Re: [Qemu-devel] [PATCH] kvmclock: clarify usage of cpu_clean_all_dirty

2014-09-16 Thread Paolo Bonzini
Il 16/09/2014 17:14, Marcelo Tosatti ha scritto: > + /* > + * Make sure that CPU state is synchronized from KVM > + * once every VM state change callback has finished. Which other callback could affect the in-kernel state, and should that call cpu_clean_all_dirty instead? Paolo > +

[Qemu-devel] [PATCH] kvmclock: clarify usage of cpu_clean_all_dirty

2014-09-16 Thread Marcelo Tosatti
Explain the cpu_clean_all_dirty call. Signed-off-by: Marcelo Tosatti --- hw/i386/kvm/clock.c |4 1 file changed, 4 insertions(+) Index: qemu/hw/i386/kvm/clock.c === --- qemu.orig/hw/i386/kvm/clock.c 2014-09-16 12:1