Re: [Qemu-devel] [PATCH] kvm: x86: Add support for -machine split-lock-ac

2018-07-05 Thread Paolo Bonzini
On 05/07/2018 10:45, Hu, Robert wrote: >> This should be a CPU feature, not a machine feature. As mentioned in the >> review of the kernel patch, please work with Robert to use the same >> infrastructure for both MSR_TEST_CTL and MSR_IA32_ARCH_CAPABILITIES. >> >> (Robert, does IceLake have this fe

Re: [Qemu-devel] [PATCH] kvm: x86: Add support for -machine split-lock-ac

2018-07-05 Thread Paolo Bonzini
On 04/07/2018 19:52, Eduardo Habkost wrote: >> (Robert, does IceLake have this feature? If so, we cannot create the >> CPU model until everything is in place). > I don't think we need to block the CPU model because QEMU+KVM > doesn't support some features yet, as long as kernel versions > capable

Re: [Qemu-devel] [PATCH] kvm: x86: Add support for -machine split-lock-ac

2018-07-05 Thread Hu, Robert
Best Regards, Robert Hoo > -Original Message- > From: Paolo Bonzini > Sent: Wednesday, July 4, 2018 21:39 > To: Liu, Jingqi > Cc: r...@twiddle.net; ehabk...@redhat.com; mtosa...@redhat.com; qemu- > de...@nongnu.org; Wang, Wei W ; Hu, Robert > > Subject: Re: [PATCH] kvm: x86: Add suppo

Re: [Qemu-devel] [PATCH] kvm: x86: Add support for -machine split-lock-ac

2018-07-04 Thread Eduardo Habkost
On Wed, Jul 04, 2018 at 03:38:32PM +0200, Paolo Bonzini wrote: > On 04/07/2018 15:12, Jingqi Liu wrote: > > Add the option split-lock-ac to control whether the #AC > > exception is generated for split locked accesses, which > > is introduced for the machine, there is an example to enable it: > > -m

Re: [Qemu-devel] [PATCH] kvm: x86: Add support for -machine split-lock-ac

2018-07-04 Thread no-reply
Hi, This series failed build test on s390x host. Please find the details below. N/A. Internal error while reading log file --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@redhat.com

Re: [Qemu-devel] [PATCH] kvm: x86: Add support for -machine split-lock-ac

2018-07-04 Thread Paolo Bonzini
On 04/07/2018 15:12, Jingqi Liu wrote: > Add the option split-lock-ac to control whether the #AC > exception is generated for split locked accesses, which > is introduced for the machine, there is an example to enable it: > -machine split-lock-ac=on > It is disabled on default. > > When bit 29 of

[Qemu-devel] [PATCH] kvm: x86: Add support for -machine split-lock-ac

2018-07-04 Thread Jingqi Liu
Add the option split-lock-ac to control whether the #AC exception is generated for split locked accesses, which is introduced for the machine, there is an example to enable it: -machine split-lock-ac=on It is disabled on default. When bit 29 of the MSR (33H) is set, the processor causes an #AC exc