On 1/24/19 12:29 PM, Markus Armbruster wrote:
>>> - block.c: JSON pseudo-filenames starting with "json:"
>>>
>>> Reproducer: https://bugzilla.redhat.com/show_bug.cgi?id=1668244#c3
>>>
>>> - block/rbd.c: JSON key pairs
>>>
>>> Pseudo-filenames starting with "rbd:".
>>>
>
Eric Blake writes:
> On 1/24/19 3:35 AM, Markus Armbruster wrote:
>
>> To gauge the bug's impact, let's review non-interpolating users of this
>> parser, i.e. code passing NULL context to json_message_parser_init():
>>
>> * tests/check-qjson.c, tests/test-qobject-input-visitor.c,
>>
On 1/24/19 3:35 AM, Markus Armbruster wrote:
> To gauge the bug's impact, let's review non-interpolating users of this
> parser, i.e. code passing NULL context to json_message_parser_init():
>
> * tests/check-qjson.c, tests/test-qobject-input-visitor.c,
> tests/test-visitor-seri
Christophe Fergeau writes:
> commit 8bca4613 added support for %% in json strings when interpolating,
> but in doing so, this broke handling of % when not interpolating as the
> '%' is skipped in both cases.
> This commit ensures we only try to handle %% when interpolating.
>
> Signed-off-by: Chr
Hey,
On Thu, Jan 24, 2019 at 10:35:52AM +0100, Markus Armbruster wrote:
> Markus Armbruster writes:
>
> > Eric Blake writes:
> >
> >> On 1/2/19 12:01 PM, Christophe Fergeau wrote:
> >>> Adding Markus to cc: list, I forgot to do it when sending the patch.
> >>
> >> Also worth backporting via qem
Markus Armbruster writes:
> Eric Blake writes:
>
>> On 1/2/19 12:01 PM, Christophe Fergeau wrote:
>>> Adding Markus to cc: list, I forgot to do it when sending the patch.
>>
>> Also worth backporting via qemu-stable, now in cc.
>>
>>>
>>> Christophe
>>>
>>> On Wed, Jan 02, 2019 at 03:05:35PM +
On Mon, Jan 07, 2019 at 04:47:44PM +0100, Markus Armbruster wrote:
> Eric Blake writes:
>
> > On 1/2/19 12:01 PM, Christophe Fergeau wrote:
> >> Adding Markus to cc: list, I forgot to do it when sending the patch.
> >
> > Also worth backporting via qemu-stable, now in cc.
> >
> >>
> >> Christoph
On Wed, Jan 02, 2019 at 03:05:35PM +0100, Christophe Fergeau wrote:
> commit 8bca4613 added support for %% in json strings when interpolating,
> but in doing so, this broke handling of % when not interpolating as the
> '%' is skipped in both cases.
> This commit ensures we only try to handle %% whe
Daniel P. Berrangé writes:
> On Wed, Jan 09, 2019 at 04:02:28PM +0100, Max Reitz wrote:
>> On 09.01.19 15:49, Daniel P. Berrangé wrote:
>> > On Wed, Jan 09, 2019 at 03:32:47PM +0100, Markus Armbruster wrote:
>> >> Max Reitz writes:
>> >>
>> >>> On 08.01.19 11:36, Markus Armbruster wrote:
>>
On Wed, Jan 09, 2019 at 04:02:28PM +0100, Max Reitz wrote:
> On 09.01.19 15:49, Daniel P. Berrangé wrote:
> > On Wed, Jan 09, 2019 at 03:32:47PM +0100, Markus Armbruster wrote:
> >> Max Reitz writes:
> >>
> >>> On 08.01.19 11:36, Markus Armbruster wrote:
> Copying block maintainers for help w
On 09.01.19 17:20, Markus Armbruster wrote:
> Max Reitz writes:
>
>> On 09.01.19 15:32, Markus Armbruster wrote:
>>> Max Reitz writes:
>>>
On 08.01.19 11:36, Markus Armbruster wrote:
> Copying block maintainers for help with assessing the bug's (non-)impact
> on security.
>
Max Reitz writes:
> On 09.01.19 15:32, Markus Armbruster wrote:
>> Max Reitz writes:
>>
>>> On 08.01.19 11:36, Markus Armbruster wrote:
Copying block maintainers for help with assessing the bug's (non-)impact
on security.
Christophe Fergeau writes:
> On Mon, Jan 07
On 09.01.19 15:49, Daniel P. Berrangé wrote:
> On Wed, Jan 09, 2019 at 03:32:47PM +0100, Markus Armbruster wrote:
>> Max Reitz writes:
>>
>>> On 08.01.19 11:36, Markus Armbruster wrote:
Copying block maintainers for help with assessing the bug's (non-)impact
on security.
Christ
On Wed, Jan 09, 2019 at 03:32:47PM +0100, Markus Armbruster wrote:
> Max Reitz writes:
>
> > On 08.01.19 11:36, Markus Armbruster wrote:
> >> Copying block maintainers for help with assessing the bug's (non-)impact
> >> on security.
> >>
> >> Christophe Fergeau writes:
> >>
> >>> On Mon, Jan 0
On 09.01.19 15:32, Markus Armbruster wrote:
> Max Reitz writes:
>
>> On 08.01.19 11:36, Markus Armbruster wrote:
>>> Copying block maintainers for help with assessing the bug's (non-)impact
>>> on security.
>>>
>>> Christophe Fergeau writes:
>>>
On Mon, Jan 07, 2019 at 04:47:44PM +0100, Mar
Max Reitz writes:
> On 08.01.19 11:36, Markus Armbruster wrote:
>> Copying block maintainers for help with assessing the bug's (non-)impact
>> on security.
>>
>> Christophe Fergeau writes:
>>
>>> On Mon, Jan 07, 2019 at 04:47:44PM +0100, Markus Armbruster wrote:
Eric Blake writes:
>
On 08.01.19 11:36, Markus Armbruster wrote:
> Copying block maintainers for help with assessing the bug's (non-)impact
> on security.
>
> Christophe Fergeau writes:
>
>> On Mon, Jan 07, 2019 at 04:47:44PM +0100, Markus Armbruster wrote:
>>> Eric Blake writes:
>>>
On 1/2/19 12:01 PM, Christ
Copying block maintainers for help with assessing the bug's (non-)impact
on security.
Christophe Fergeau writes:
> On Mon, Jan 07, 2019 at 04:47:44PM +0100, Markus Armbruster wrote:
>> Eric Blake writes:
>>
>> > On 1/2/19 12:01 PM, Christophe Fergeau wrote:
>> >> Adding Markus to cc: list, I f
On Mon, Jan 07, 2019 at 04:47:44PM +0100, Markus Armbruster wrote:
> Eric Blake writes:
>
> > On 1/2/19 12:01 PM, Christophe Fergeau wrote:
> >> Adding Markus to cc: list, I forgot to do it when sending the patch.
> >
> > Also worth backporting via qemu-stable, now in cc.
> >
> >>
> >> Christoph
On 1/7/19 9:47 AM, Markus Armbruster wrote:
> Eric Blake writes:
>
>> On 1/2/19 12:01 PM, Christophe Fergeau wrote:
>>> Adding Markus to cc: list, I forgot to do it when sending the patch.
>>
>> Also worth backporting via qemu-stable, now in cc.
>>
>>>
>>> Christophe
>>>
>>> On Wed, Jan 02, 2019
Eric Blake writes:
> On 1/2/19 12:01 PM, Christophe Fergeau wrote:
>> Adding Markus to cc: list, I forgot to do it when sending the patch.
>
> Also worth backporting via qemu-stable, now in cc.
>
>>
>> Christophe
>>
>> On Wed, Jan 02, 2019 at 03:05:35PM +0100, Christophe Fergeau wrote:
>>> comm
On 1/2/19 12:01 PM, Christophe Fergeau wrote:
> Adding Markus to cc: list, I forgot to do it when sending the patch.
Also worth backporting via qemu-stable, now in cc.
>
> Christophe
>
> On Wed, Jan 02, 2019 at 03:05:35PM +0100, Christophe Fergeau wrote:
>> commit 8bca4613 added support for %%
Adding Markus to cc: list, I forgot to do it when sending the patch.
Christophe
On Wed, Jan 02, 2019 at 03:05:35PM +0100, Christophe Fergeau wrote:
> commit 8bca4613 added support for %% in json strings when interpolating,
> but in doing so, this broke handling of % when not interpolating as the
commit 8bca4613 added support for %% in json strings when interpolating,
but in doing so, this broke handling of % when not interpolating as the
'%' is skipped in both cases.
This commit ensures we only try to handle %% when interpolating.
Signed-off-by: Christophe Fergeau
---
qobject/json-parse
24 matches
Mail list logo
