Re: [Qemu-devel] [PATCH] ivshmem: fix memory backend leak

2018-11-06 Thread Paolo Bonzini
On 01/11/2018 11:44, Igor Mammedov wrote: > object_new() returns a new backend with refcount == 1 and > then later object_property_add_child() increases refcount to 2 > So when ivshmem is desroyed, the backend it has created isn't > destroyed along with it as children cleanup will bring > backend's

Re: [Qemu-devel] [PATCH] ivshmem: fix memory backend leak

2018-11-05 Thread Markus Armbruster
Igor Mammedov writes: > On Thu, 1 Nov 2018 15:02:04 +0400 > Marc-André Lureau wrote: > >> On Thu, Nov 1, 2018 at 2:53 PM Igor Mammedov wrote: >> > >> > object_new() returns a new backend with refcount == 1 and >> > then later object_property_add_child() increases refcount to 2 >> > So when ivsh

Re: [Qemu-devel] [PATCH] ivshmem: fix memory backend leak

2018-11-01 Thread Igor Mammedov
On Thu, 1 Nov 2018 15:27:02 +0100 Philippe Mathieu-Daudé wrote: > On 1/11/18 11:44, Igor Mammedov wrote: > > object_new() returns a new backend with refcount == 1 and > > then later object_property_add_child() increases refcount to 2 > > So when ivshmem is desroyed, the backend it has created isn

Re: [Qemu-devel] [PATCH] ivshmem: fix memory backend leak

2018-11-01 Thread Philippe Mathieu-Daudé
On 1/11/18 11:44, Igor Mammedov wrote: object_new() returns a new backend with refcount == 1 and then later object_property_add_child() increases refcount to 2 So when ivshmem is desroyed, the backend it has created isn't ^ "destroyed" destroyed along with it as children

Re: [Qemu-devel] [PATCH] ivshmem: fix memory backend leak

2018-11-01 Thread Igor Mammedov
On Thu, 1 Nov 2018 15:02:04 +0400 Marc-André Lureau wrote: > On Thu, Nov 1, 2018 at 2:53 PM Igor Mammedov wrote: > > > > object_new() returns a new backend with refcount == 1 and > > then later object_property_add_child() increases refcount to 2 > > So when ivshmem is desroyed, the backend it ha

Re: [Qemu-devel] [PATCH] ivshmem: fix memory backend leak

2018-11-01 Thread Marc-André Lureau
On Thu, Nov 1, 2018 at 2:53 PM Igor Mammedov wrote: > > object_new() returns a new backend with refcount == 1 and > then later object_property_add_child() increases refcount to 2 > So when ivshmem is desroyed, the backend it has created isn't > destroyed along with it as children cleanup will brin

[Qemu-devel] [PATCH] ivshmem: fix memory backend leak

2018-11-01 Thread Igor Mammedov
object_new() returns a new backend with refcount == 1 and then later object_property_add_child() increases refcount to 2 So when ivshmem is desroyed, the backend it has created isn't destroyed along with it as children cleanup will bring backend's refcount only to 1, which leaks backend including r