Re: [Qemu-devel] [PATCH] isapc: Fix segfault during initialization

2012-01-15 Thread Anthony Liguori
On 01/15/2012 10:16 AM, Jan Kiszka wrote: On 2012-01-15 17:12, Anthony Liguori wrote: On 01/15/2012 08:40 AM, Jan Kiszka wrote: On 2012-01-15 15:38, Anthony Liguori wrote: On 01/14/2012 07:12 AM, Jan Kiszka wrote: From: Jan Kiszka Linking the RTC device state to the PIIX does not belong into

Re: [Qemu-devel] [PATCH] isapc: Fix segfault during initialization

2012-01-15 Thread Jan Kiszka
On 2012-01-15 17:12, Anthony Liguori wrote: > On 01/15/2012 08:40 AM, Jan Kiszka wrote: >> On 2012-01-15 15:38, Anthony Liguori wrote: >>> On 01/14/2012 07:12 AM, Jan Kiszka wrote: From: Jan Kiszka Linking the RTC device state to the PIIX does not belong into the common path tha

Re: [Qemu-devel] [PATCH] isapc: Fix segfault during initialization

2012-01-15 Thread Anthony Liguori
On 01/15/2012 08:40 AM, Jan Kiszka wrote: On 2012-01-15 15:38, Anthony Liguori wrote: On 01/14/2012 07:12 AM, Jan Kiszka wrote: From: Jan Kiszka Linking the RTC device state to the PIIX does not belong into the common path that is shared with the isapc. QEMU crashes otherwise. Signed-off-by:

Re: [Qemu-devel] [PATCH] isapc: Fix segfault during initialization

2012-01-15 Thread Jan Kiszka
On 2012-01-15 15:38, Anthony Liguori wrote: > On 01/14/2012 07:12 AM, Jan Kiszka wrote: >> From: Jan Kiszka >> >> Linking the RTC device state to the PIIX does not belong into the >> common path that is shared with the isapc. QEMU crashes otherwise. >> >> Signed-off-by: Jan Kiszka > > Does isapc a

Re: [Qemu-devel] [PATCH] isapc: Fix segfault during initialization

2012-01-15 Thread Anthony Liguori
On 01/14/2012 07:12 AM, Jan Kiszka wrote: From: Jan Kiszka Linking the RTC device state to the PIIX does not belong into the common path that is shared with the isapc. QEMU crashes otherwise. Signed-off-by: Jan Kiszka Does isapc actually work for you? I tried to write a qemu-test test case

Re: [Qemu-devel] [PATCH] isapc: Fix segfault during initialization

2012-01-14 Thread Andreas Färber
Am 14.01.2012 14:12, schrieb Jan Kiszka: > From: Jan Kiszka > > Linking the RTC device state to the PIIX does not belong into the > common path that is shared with the isapc. QEMU crashes otherwise. Doesn't that indicate a missing NULL-check or something in qdev_property_add_child() that should

[Qemu-devel] [PATCH] isapc: Fix segfault during initialization

2012-01-14 Thread Jan Kiszka
From: Jan Kiszka Linking the RTC device state to the PIIX does not belong into the common path that is shared with the isapc. QEMU crashes otherwise. Signed-off-by: Jan Kiszka --- hw/pc_piix.c | 22 +++--- 1 files changed, 11 insertions(+), 11 deletions(-) diff --git a/hw/pc

Re: [Qemu-devel] [PATCH] isapc: fix segfault.

2010-08-28 Thread Blue Swirl
Thanks, applied. On Tue, Aug 24, 2010 at 5:06 AM, Isaku Yamahata wrote: > Ping. > > On Wed, Aug 04, 2010 at 05:43:20PM +0900, Isaku Yamahata wrote: >> https://bugs.launchpad.net/bugs/611646 >> reports that ./i386-softmmu/qemu -M isapc segfaults. >> This patch fixes the segfault introduced by >> f

Re: [Qemu-devel] [PATCH] isapc: fix segfault.

2010-08-23 Thread Isaku Yamahata
Ping. On Wed, Aug 04, 2010 at 05:43:20PM +0900, Isaku Yamahata wrote: > https://bugs.launchpad.net/bugs/611646 > reports that ./i386-softmmu/qemu -M isapc segfaults. > This patch fixes the segfault introduced by > f885f1eaa8711c06033ceb1599e3750fb37c306f > > It's because i440fx_state in pc_init1(

[Qemu-devel] [PATCH] isapc: fix segfault.

2010-08-04 Thread Isaku Yamahata
https://bugs.launchpad.net/bugs/611646 reports that ./i386-softmmu/qemu -M isapc segfaults. This patch fixes the segfault introduced by f885f1eaa8711c06033ceb1599e3750fb37c306f It's because i440fx_state in pc_init1() isn't initialized. > Core was generated by `./i386-softmmu/qemu -M isapc'. > Pro