On 03/30/2017 12:14 PM, Ed Maste wrote:
On 30 March 2017 at 12:12, Corey Minyard wrote:
This isn't quite right, a lot of these need parenthesis around the whole
thing, and some of the macros are unused and need to be removed.
I had submitted something for this a while ago, but it hadn't been
ta
On 30 March 2017 at 12:12, Corey Minyard wrote:
> This isn't quite right, a lot of these need parenthesis around the whole
> thing, and some of the macros are unused and need to be removed.
> I had submitted something for this a while ago, but it hadn't been
> taken. I will re-submit.
Ok, thanks
This isn't quite right, a lot of these need parenthesis around the whole
thing, and some of the macros are unused and need to be removed.
I had submitted something for this a while ago, but it hadn't been
taken. I will re-submit.
-corey
On 03/30/2017 06:22 PM, Ed Maste wrote:
Found via Clang w
On 03/30/2017 06:22 PM, Ed Maste wrote:
> Found via Clang warning: logical not is only applied to the left hand
> side of this bitwise operator [-Wlogical-not-parentheses]
>
> !IPMI_BT_GET_HBUSY(ib->control_reg));
> ^~
Found via Clang warning: logical not is only applied to the left hand
side of this bitwise operator [-Wlogical-not-parentheses]
!IPMI_BT_GET_HBUSY(ib->control_reg));
^~~~
expanded from macro 'IPMI_BT_SET_H
