Re: [Qemu-devel] [PATCH] iotests: Fix CID for VMDK afl image

2018-02-01 Thread Eric Blake
On 02/01/2018 11:59 AM, Max Reitz wrote: >>> H, now this fails again on my 32 bit build. :-( >>> >>> The issue there is that you get a "Cannot allocate memory" when trying >>> to open the file. My current fix was 2291712c39111a732 which simply >>> converted that to "Invalid argument", but now

Re: [Qemu-devel] [PATCH] iotests: Fix CID for VMDK afl image

2018-02-01 Thread Max Reitz
On 2018-02-01 01:55, Fam Zheng wrote: > On Thu, Feb 1, 2018 at 2:58 AM, Max Reitz wrote: >> On 2018-01-30 07:25, Fam Zheng wrote: >>> This reverts commit 76bf133c4 which updated the reference output, and >>> fixed the reference image, because the code path we want to exercise is >>> actually the i

Re: [Qemu-devel] [PATCH] iotests: Fix CID for VMDK afl image

2018-01-31 Thread Fam Zheng
On Thu, Feb 1, 2018 at 2:58 AM, Max Reitz wrote: > On 2018-01-30 07:25, Fam Zheng wrote: >> This reverts commit 76bf133c4 which updated the reference output, and >> fixed the reference image, because the code path we want to exercise is >> actually the invalid image size. >> >> The descriptor bloc

Re: [Qemu-devel] [PATCH] iotests: Fix CID for VMDK afl image

2018-01-31 Thread Max Reitz
On 2018-01-30 07:25, Fam Zheng wrote: > This reverts commit 76bf133c4 which updated the reference output, and > fixed the reference image, because the code path we want to exercise is > actually the invalid image size. > > The descriptor block in the image, which includes the CID to verify, has be

Re: [Qemu-devel] [PATCH] iotests: Fix CID for VMDK afl image

2018-01-30 Thread Kevin Wolf
Am 30.01.2018 um 07:25 hat Fam Zheng geschrieben: > This reverts commit 76bf133c4 which updated the reference output, and > fixed the reference image, because the code path we want to exercise is > actually the invalid image size. > > The descriptor block in the image, which includes the CID to ve

Re: [Qemu-devel] [PATCH] iotests: Fix CID for VMDK afl image

2018-01-30 Thread Fam Zheng
On Tue, Jan 30, 2018 at 9:48 PM, Eric Blake wrote: > On 01/30/2018 12:25 AM, Fam Zheng wrote: >> This reverts commit 76bf133c4 which updated the reference output, and >> fixed the reference image, because the code path we want to exercise is >> actually the invalid image size. >> >> The descriptor

Re: [Qemu-devel] [PATCH] iotests: Fix CID for VMDK afl image

2018-01-30 Thread Eric Blake
On 01/30/2018 12:25 AM, Fam Zheng wrote: > This reverts commit 76bf133c4 which updated the reference output, and > fixed the reference image, because the code path we want to exercise is > actually the invalid image size. > > The descriptor block in the image, which includes the CID to verify, has

Re: [Qemu-devel] [PATCH] iotests: Fix CID for VMDK afl image

2018-01-29 Thread Fam Zheng
On Mon, Jan 29, 2018 at 11:49 PM, Kevin Wolf wrote: > Am 24.01.2018 um 05:42 hat Fam Zheng geschrieben: >> The descriptor block in the image, which includes the CID to verify, has been >> invalid since the reference image was added. Since commit 9877860e7bd we >> report >> this error earlier than

[Qemu-devel] [PATCH] iotests: Fix CID for VMDK afl image

2018-01-29 Thread Fam Zheng
This reverts commit 76bf133c4 which updated the reference output, and fixed the reference image, because the code path we want to exercise is actually the invalid image size. The descriptor block in the image, which includes the CID to verify, has been invalid since the reference image was added.

Re: [Qemu-devel] [PATCH] iotests: Fix CID for VMDK afl image

2018-01-29 Thread Kevin Wolf
Am 24.01.2018 um 05:42 hat Fam Zheng geschrieben: > The descriptor block in the image, which includes the CID to verify, has been > invalid since the reference image was added. Since commit 9877860e7bd we > report > this error earlier than the "file too large", so 059.out mismatches. > > Instead

[Qemu-devel] [PATCH] iotests: Fix CID for VMDK afl image

2018-01-23 Thread Fam Zheng
The descriptor block in the image, which includes the CID to verify, has been invalid since the reference image was added. Since commit 9877860e7bd we report this error earlier than the "file too large", so 059.out mismatches. Instead of fixing the output, we fix the image descriptor, because the