Re: [Qemu-devel] [PATCH] iotests: Drop use of bash keyword 'function'

2018-11-19 Thread Philippe Mathieu-Daudé
On 16/11/18 22:50, Eric Blake wrote: Bash allows functions to be declared with or without the leading keyword 'function'; but including the keyword does not comply with POSIX syntax, and is confusing to ksh users where the use of the keyword changes the scoping rules for functions. Stick to the

Re: [Qemu-devel] [PATCH] iotests: Drop use of bash keyword 'function'

2018-11-19 Thread Daniel P . Berrangé
On Fri, Nov 16, 2018 at 03:50:02PM -0600, Eric Blake wrote: > Bash allows functions to be declared with or without the leading > keyword 'function'; but including the keyword does not comply with > POSIX syntax, and is confusing to ksh users where the use of the > keyword changes the scoping rules

[Qemu-devel] [PATCH] iotests: Drop use of bash keyword 'function'

2018-11-16 Thread Eric Blake
Bash allows functions to be declared with or without the leading keyword 'function'; but including the keyword does not comply with POSIX syntax, and is confusing to ksh users where the use of the keyword changes the scoping rules for functions. Stick to the POSIX form through iotests. Done mecha