This patch will be useful, but there is a security problem in its
current form. The qemu-user-static package installs binfmt-misc
entries with "flags: OC", which makes the binary honor setuid bits.
Regardless of whether it is a good idea or not, the envvars ought to
be ignored in such a case. So
Rework option parsing code for linux-user in a table-driven manner to allow
environment variables for all commandline options.
Also generate usage() output from option table.
Fix complains from checkpatch.pl, also have envlist global
Signed-off-by: Johannes Schauer
---
linux-user/main.c | 53
On 31 July 2011 22:40, Johannes Schauer wrote:
> Rework option parsing code for linux-user in a table-driven manner to allow
> environment variables for all commandline options.
>
> Also generate usage() output from option table.
Thanks for this, it looks good. A couple of minor points:
(1) what'
Rework option parsing code for linux-user in a table-driven manner to allow
environment variables for all commandline options.
Also generate usage() output from option table.
Signed-off-by: Johannes Schauer
---
linux-user/main.c | 518 ++---
1
On 31 July 2011 12:51, wrote:
> + if ((r = getenv("QEMU_STACK_SIZE")) != NULL) {
> + guest_stack_size = strtoul(r, (char **)&r, 0);
> + if (guest_stack_size == 0)
> + usage();
> + if (*r == 'M')
> + guest_stack_size *= 1024 * 1024;
> + else if
From: Johannes Schauer
A first try to introduce a generic setup for mapping environment variables to
command line options.
I'm afraid to code something for platforms I can't do runtime tests on, so this
is only for linux-user for now.
Signed-off-by: Johannes Schauer
---
linux-user/main.c |
