Re: [Qemu-devel] [PATCH] intel_iommu: fix VTD_SID_TO_BUS

2014-10-20 Thread Knut Omang
On Mon, 2014-10-20 at 21:03 +0200, Knut Omang wrote: > On Mon, 2014-10-20 at 20:18 +0200, Jan Kiszka wrote: > > On 2014-10-20 17:15, Knut Omang wrote: > > > On Mon, 2014-10-20 at 17:23 +0300, Michael S. Tsirkin wrote: > > >> WRT intel_iommu, it does not yet seem to be as fully functional as I > > >

Re: [Qemu-devel] [PATCH] intel_iommu: fix VTD_SID_TO_BUS

2014-10-20 Thread Knut Omang
On Mon, 2014-10-20 at 21:03 +0200, Knut Omang wrote: > On Mon, 2014-10-20 at 20:18 +0200, Jan Kiszka wrote: > > On 2014-10-20 17:15, Knut Omang wrote: > > > On Mon, 2014-10-20 at 17:23 +0300, Michael S. Tsirkin wrote: > > >> WRT intel_iommu, it does not yet seem to be as fully functional as I > > >

Re: [Qemu-devel] [PATCH] intel_iommu: fix VTD_SID_TO_BUS

2014-10-20 Thread Knut Omang
On Mon, 2014-10-20 at 20:18 +0200, Jan Kiszka wrote: > On 2014-10-20 17:15, Knut Omang wrote: > > On Mon, 2014-10-20 at 17:23 +0300, Michael S. Tsirkin wrote: > >> WRT intel_iommu, it does not yet seem to be as fully functional as I > >> hoped. People also discussed the best way to handle virtio v

Re: [Qemu-devel] [PATCH] intel_iommu: fix VTD_SID_TO_BUS

2014-10-20 Thread Jan Kiszka
On 2014-10-20 19:20, Michael S. Tsirkin wrote: > On Mon, Oct 20, 2014 at 04:37:15PM +0200, Jan Kiszka wrote: >> On 2014-10-20 16:23, Michael S. Tsirkin wrote: >>> >>> WRT intel_iommu, it does not yet seem to be as fully functional as I >>> hoped. >> >> What is missing or broken? > > PCI to PCI bri

Re: [Qemu-devel] [PATCH] intel_iommu: fix VTD_SID_TO_BUS

2014-10-20 Thread Jan Kiszka
On 2014-10-20 17:15, Knut Omang wrote: > On Mon, 2014-10-20 at 17:23 +0300, Michael S. Tsirkin wrote: >> WRT intel_iommu, it does not yet seem to be as fully functional as I >> hoped. People also discussed the best way to handle virtio versus iommu >> (it bypasses it ATM). >> I'd like to suggest w

Re: [Qemu-devel] [PATCH] intel_iommu: fix VTD_SID_TO_BUS

2014-10-20 Thread Michael S. Tsirkin
On Mon, Oct 20, 2014 at 04:37:15PM +0200, Jan Kiszka wrote: > On 2014-10-20 16:23, Michael S. Tsirkin wrote: > > > > WRT intel_iommu, it does not yet seem to be as fully functional as I > > hoped. > > What is missing or broken? PCI to PCI bridges don't work, do they? > > People also discussed

Re: [Qemu-devel] [PATCH] intel_iommu: fix VTD_SID_TO_BUS

2014-10-20 Thread Knut Omang
On Mon, 2014-10-20 at 17:23 +0300, Michael S. Tsirkin wrote: > WRT intel_iommu, it does not yet seem to be as fully functional as I > hoped. People also discussed the best way to handle virtio versus iommu > (it bypasses it ATM). > I'd like to suggest we hide the iommu from the command line > help

Re: [Qemu-devel] [PATCH] intel_iommu: fix VTD_SID_TO_BUS

2014-10-20 Thread Knut Omang
On Mon, 2014-10-20 at 20:14 +0800, Le Tan wrote: > Hi Markus, > > 2014-10-20 19:41 GMT+08:00 Markus Armbruster : > > "Michael S. Tsirkin" writes: > > > >> (((sid) >> 8) && 0xff) makes no sense > >> (((sid) >> 8) & 0xff) seems to be what was meant. > >> > >> Suggested-by: Markus Armbruster > > >

Re: [Qemu-devel] [PATCH] intel_iommu: fix VTD_SID_TO_BUS

2014-10-20 Thread Jan Kiszka
On 2014-10-20 16:23, Michael S. Tsirkin wrote: > > WRT intel_iommu, it does not yet seem to be as fully functional as I > hoped. What is missing or broken? > People also discussed the best way to handle virtio versus iommu > (it bypasses it ATM). We need to declare in the ACPI tables that the

Re: [Qemu-devel] [PATCH] intel_iommu: fix VTD_SID_TO_BUS

2014-10-20 Thread Michael S. Tsirkin
WRT intel_iommu, it does not yet seem to be as fully functional as I hoped. People also discussed the best way to handle virtio versus iommu (it bypasses it ATM). I'd like to suggest we hide the iommu from the command line help for 2.2, this way people don't activate it mistakenly. Let's make it

Re: [Qemu-devel] [PATCH] intel_iommu: fix VTD_SID_TO_BUS

2014-10-20 Thread Le Tan
Hi Markus, 2014-10-20 19:41 GMT+08:00 Markus Armbruster : > "Michael S. Tsirkin" writes: > >> (((sid) >> 8) && 0xff) makes no sense >> (((sid) >> 8) & 0xff) seems to be what was meant. >> >> Suggested-by: Markus Armbruster > > Actually by the reporter of https://bugs.launchpad.net/bugs/1382477

Re: [Qemu-devel] [PATCH] intel_iommu: fix VTD_SID_TO_BUS

2014-10-20 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > (((sid) >> 8) && 0xff) makes no sense > (((sid) >> 8) & 0xff) seems to be what was meant. > > Suggested-by: Markus Armbruster Actually by the reporter of https://bugs.launchpad.net/bugs/1382477 > Signed-off-by: Michael S. Tsirkin > --- > > Compile-tested only.

[Qemu-devel] [PATCH] intel_iommu: fix VTD_SID_TO_BUS

2014-10-20 Thread Michael S. Tsirkin
(((sid) >> 8) && 0xff) makes no sense (((sid) >> 8) & 0xff) seems to be what was meant. Suggested-by: Markus Armbruster Signed-off-by: Michael S. Tsirkin --- Compile-tested only. include/hw/i386/intel_iommu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/i386