Re: [Qemu-devel] [PATCH] intel-iommu: send PSI always when notify_unmap set

2018-04-20 Thread Jason Wang
On 2018年04月18日 12:51, Peter Xu wrote: During IOVA page table walk, there is a special case when: - notify_unmap is set, meanwhile - entry is invalid In the past, we skip the entry always. This is not correct. We should send UNMAP notification to registered notifiers in this case. Otherwise

Re: [Qemu-devel] [PATCH] intel-iommu: send PSI always when notify_unmap set

2018-04-20 Thread Jason Wang
On 2018年04月20日 13:11, Peter Xu wrote: On Fri, Apr 20, 2018 at 12:57:13PM +0800, Jason Wang wrote: On 2018年04月18日 12:51, Peter Xu wrote: During IOVA page table walk, there is a special case when: - notify_unmap is set, meanwhile - entry is invalid In the past, we skip the entry always. This

Re: [Qemu-devel] [PATCH] intel-iommu: send PSI always when notify_unmap set

2018-04-19 Thread Peter Xu
On Fri, Apr 20, 2018 at 12:57:13PM +0800, Jason Wang wrote: > > > On 2018年04月18日 12:51, Peter Xu wrote: > > During IOVA page table walk, there is a special case when: > > > > - notify_unmap is set, meanwhile > > - entry is invalid > > > > In the past, we skip the entry always. This is not corr

Re: [Qemu-devel] [PATCH] intel-iommu: send PSI always when notify_unmap set

2018-04-19 Thread Jason Wang
On 2018年04月18日 12:51, Peter Xu wrote: During IOVA page table walk, there is a special case when: - notify_unmap is set, meanwhile - entry is invalid In the past, we skip the entry always. This is not correct. We should send UNMAP notification to registered notifiers in this case. Otherwise

Re: [Qemu-devel] [PATCH] intel-iommu: send PSI always when notify_unmap set

2018-04-17 Thread Peter Xu
On Wed, Apr 18, 2018 at 05:29:56AM +, Liu, Yi L wrote: > > Sent: Wednesday, April 18, 2018 12:51 PM > > Subject: [Qemu-devel] [PATCH] intel-iommu: send PSI always when notify_unmap > > set > > > > During IOVA page table walk, there is a special case when:

Re: [Qemu-devel] [PATCH] intel-iommu: send PSI always when notify_unmap set

2018-04-17 Thread Liu, Yi L
> Sent: Wednesday, April 18, 2018 12:51 PM > Subject: [Qemu-devel] [PATCH] intel-iommu: send PSI always when notify_unmap > set > > During IOVA page table walk, there is a special case when: > > - notify_unmap is set, meanwhile > - entry is invalid This is very brief des

Re: [Qemu-devel] [PATCH] intel-iommu: send PSI always when notify_unmap set

2018-04-17 Thread Peter Xu
On Wed, Apr 18, 2018 at 12:51:21PM +0800, Peter Xu wrote: > During IOVA page table walk, there is a special case when: > > - notify_unmap is set, meanwhile > - entry is invalid > > In the past, we skip the entry always. This is not correct. We should > send UNMAP notification to registered noti

[Qemu-devel] [PATCH] intel-iommu: send PSI always when notify_unmap set

2018-04-17 Thread Peter Xu
During IOVA page table walk, there is a special case when: - notify_unmap is set, meanwhile - entry is invalid In the past, we skip the entry always. This is not correct. We should send UNMAP notification to registered notifiers in this case. Otherwise some stall pages will still be mapped in