Re: [Qemu-devel] [PATCH] imx.31 and KZM board support

2011-11-23 Thread Juan Quintela
Peter Maydell wrote: > On 22 November 2011 11:06, Juan Quintela wrote: >> Peter Chubb wrote: >> >>       vmstate_register(&dev->qdev, -1, &vmstate_imxg_timer, s); >> ??? > > Any particular reason to prefer a vmstate_register() call > over just having a SysBusDeviceInfo struct with the .qdev.vms

Re: [Qemu-devel] [PATCH] imx.31 and KZM board support

2011-11-22 Thread Peter Chubb
> "Juan" == Juan Quintela writes: Juan> Peter Chubb wrote: Juan> This is not used. Shouldn't a call like this be needed? Juan>vmstate_register(&dev->qdev, -1, &vmstate_imxg_timer, s); Juan> ??? Yes!! Thanks for checking. I've altered the source ready for the next rollout of patc

Re: [Qemu-devel] [PATCH] imx.31 and KZM board support

2011-11-22 Thread Peter Maydell
On 22 November 2011 11:06, Juan Quintela wrote: > Peter Chubb wrote: >> Hi Peter, >>    Please find appended a patch containing initial support for the >>    FreeScale i.MX31 and the KZM Arm11 evaluation board. >> >>    The implementation was originally written by Hans Jang and Adam >>    Clench

Re: [Qemu-devel] [PATCH] imx.31 and KZM board support

2011-11-22 Thread Juan Quintela
Peter Chubb wrote: > Hi Peter, >Please find appended a patch containing initial support for the >FreeScale i.MX31 and the KZM Arm11 evaluation board. > >The implementation was originally written by Hans Jang and Adam >Clench of OK-Labs; I've updated it to the current qdev and memor

Re: [Qemu-devel] [PATCH] imx.31 and KZM board support

2011-11-21 Thread Peter Chubb
> "Peter" == Peter Maydell writes: Peter> On 21 November 2011 23:54, Peter Chubb Peter> wrote: >> Do you have a suggestion for an alternative to hw_error for guest >> bad behaviour?  It seems to be used historically.  For emulating >> ARM, causing qemu to stop isn't such a bad idea ... the g

Re: [Qemu-devel] [PATCH] imx.31 and KZM board support

2011-11-21 Thread Peter Maydell
On 22 November 2011 00:27, Peter Chubb wrote: >> "Peter" == Peter Maydell writes: > > Peter> On 21 November 2011 23:54, Peter Chubb > Peter> wrote: >>> Do you have a suggestion for an alternative to hw_error for guest >>> bad behaviour?  It seems to be used historically.  For emulating >>> A

Re: [Qemu-devel] [PATCH] imx.31 and KZM board support

2011-11-21 Thread Peter Maydell
On 21 November 2011 23:54, Peter Chubb wrote: > Do you have a suggestion for an alternative to hw_error for guest bad > behaviour?  It seems to be used historically.  For emulating ARM, > causing qemu to stop isn't such a bad idea ... the guest does > something wrong and the qemu instance dies wit

Re: [Qemu-devel] [PATCH] imx.31 and KZM board support

2011-11-21 Thread Peter Chubb
Thanks Peter, I'll split the patches and resubmit. It'll probably be tomorrow or Thursday. Do you have a suggestion for an alternative to hw_error for guest bad behaviour? It seems to be used historically. For emulating ARM, causing qemu to stop isn't such a bad idea ... the guest does somethin

Re: [Qemu-devel] [PATCH] imx.31 and KZM board support

2011-11-21 Thread Peter Maydell
On 21 November 2011 21:58, Peter Chubb wrote: > Hi Peter, >   Please find appended a patch containing initial support for the >   FreeScale i.MX31 and the KZM Arm11 evaluation board. > >   The implementation was originally written by Hans Jang and Adam >   Clench of OK-Labs; I've updated it to the

Re: [Qemu-devel] [PATCH] imx.31 and KZM board support

2011-11-21 Thread Peter Maydell
On 21 November 2011 23:04, Peter Chubb wrote: >> "Andreas" == Andreas Färber writes: >>> ??? Save/restore.  */ > > Andreas> What does this comment tell us? :) > > Dunno.  It was in the codebase I got; I think it means that save and > restore aren't implemented yet. I think what Andreas is t

Re: [Qemu-devel] [PATCH] imx.31 and KZM board support

2011-11-21 Thread Peter Chubb
> "Andreas" == Andreas Färber writes: Andreas> Hi Peter, Am 21.11.2011 22:58, schrieb Peter Chubb: >> Hi Peter, Please find appended a patch containing initial support >> for the FreeScale i.MX31 and the KZM Arm11 evaluation board. Andreas> Your patch format is a bit unusual. Andreas> Pleas

Re: [Qemu-devel] [PATCH] imx.31 and KZM board support

2011-11-21 Thread Andreas Färber
Hi Peter, Am 21.11.2011 22:58, schrieb Peter Chubb: > Hi Peter, >Please find appended a patch containing initial support for the >FreeScale i.MX31 and the KZM Arm11 evaluation board. Your patch format is a bit unusual. Please don't include personal messages in the description, keep it in

[Qemu-devel] [PATCH] imx.31 and KZM board support

2011-11-21 Thread Peter Chubb
Hi Peter, Please find appended a patch containing initial support for the FreeScale i.MX31 and the KZM Arm11 evaluation board. The implementation was originally written by Hans Jang and Adam Clench of OK-Labs; I've updated it to the current qdev and memory region paradigms and imple