Re: [Qemu-devel] [PATCH] ide: log error when trying to use ATAPI overlapping features

2013-02-12 Thread Stefan Hajnoczi
On Mon, Feb 11, 2013 at 04:10:46PM +0100, Andreas Färber wrote: > Am 11.02.2013 15:57, schrieb Stefan Hajnoczi: > > On Mon, Feb 11, 2013 at 3:34 PM, Peter Maydell > > wrote: > >> On 11 February 2013 14:19, Andreas Färber wrote: > >>> Am 11.02.2013 15:01, schrieb Markus Armbruster: > Kevin W

Re: [Qemu-devel] [PATCH] ide: log error when trying to use ATAPI overlapping features

2013-02-11 Thread Hervé Poussineau
Peter Maydell a écrit : On 10 February 2013 22:12, Hervé Poussineau wrote: --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -1394,8 +1394,10 @@ void ide_exec_cmd(IDEBus *bus, uint32_t val) break; case WIN_PACKETCMD: /* overlapping commands not supported */ -if (s->featu

Re: [Qemu-devel] [PATCH] ide: log error when trying to use ATAPI overlapping features

2013-02-11 Thread Andreas Färber
Am 11.02.2013 15:57, schrieb Stefan Hajnoczi: > On Mon, Feb 11, 2013 at 3:34 PM, Peter Maydell > wrote: >> On 11 February 2013 14:19, Andreas Färber wrote: >>> Am 11.02.2013 15:01, schrieb Markus Armbruster: Kevin Wolf writes: > Am 11.02.2013 14:27, schrieb Stefan Hajnoczi: >>

Re: [Qemu-devel] [PATCH] ide: log error when trying to use ATAPI overlapping features

2013-02-11 Thread Peter Maydell
On 10 February 2013 22:12, Hervé Poussineau wrote: > --- a/hw/ide/core.c > +++ b/hw/ide/core.c > @@ -1394,8 +1394,10 @@ void ide_exec_cmd(IDEBus *bus, uint32_t val) > break; > case WIN_PACKETCMD: > /* overlapping commands not supported */ > -if (s->feature & 0x02) >

Re: [Qemu-devel] [PATCH] ide: log error when trying to use ATAPI overlapping features

2013-02-11 Thread Peter Maydell
On 11 February 2013 14:57, Stefan Hajnoczi wrote: > On Mon, Feb 11, 2013 at 3:34 PM, Peter Maydell > wrote: >> On 11 February 2013 14:19, Andreas Färber wrote: >>> Blue already did some work to make it more usable, and I believe Peter >>> adopted LOG_UNIMPL for ARM devices in place of hw_error(

Re: [Qemu-devel] [PATCH] ide: log error when trying to use ATAPI overlapping features

2013-02-11 Thread Stefan Hajnoczi
On Mon, Feb 11, 2013 at 3:34 PM, Peter Maydell wrote: > On 11 February 2013 14:19, Andreas Färber wrote: >> Am 11.02.2013 15:01, schrieb Markus Armbruster: >>> Kevin Wolf writes: >>> Am 11.02.2013 14:27, schrieb Stefan Hajnoczi: > I think we need to side-track this patch email to figure

Re: [Qemu-devel] [PATCH] ide: log error when trying to use ATAPI overlapping features

2013-02-11 Thread Peter Maydell
On 11 February 2013 14:19, Andreas Färber wrote: > Am 11.02.2013 15:01, schrieb Markus Armbruster: >> Kevin Wolf writes: >> >>> Am 11.02.2013 14:27, schrieb Stefan Hajnoczi: I think we need to side-track this patch email to figure out what to use: fprintf(stderr) - some warnin

Re: [Qemu-devel] [PATCH] ide: log error when trying to use ATAPI overlapping features

2013-02-11 Thread Andreas Färber
Am 11.02.2013 15:01, schrieb Markus Armbruster: > Kevin Wolf writes: > >> Am 11.02.2013 14:27, schrieb Stefan Hajnoczi: >>> On Sun, Feb 10, 2013 at 11:12:11PM +0100, Hervé Poussineau wrote: Signed-off-by: Hervé Poussineau --- hw/ide/core.c |4 +++- 1 file changed, 3

Re: [Qemu-devel] [PATCH] ide: log error when trying to use ATAPI overlapping features

2013-02-11 Thread Markus Armbruster
Kevin Wolf writes: > Am 11.02.2013 14:27, schrieb Stefan Hajnoczi: >> On Sun, Feb 10, 2013 at 11:12:11PM +0100, Hervé Poussineau wrote: >>> >>> Signed-off-by: Hervé Poussineau >>> --- >>> hw/ide/core.c |4 +++- >>> 1 file changed, 3 insertions(+), 1 deletion(-) >>> >>> diff --git a/hw/ide/c

Re: [Qemu-devel] [PATCH] ide: log error when trying to use ATAPI overlapping features

2013-02-11 Thread Kevin Wolf
Am 11.02.2013 14:27, schrieb Stefan Hajnoczi: > On Sun, Feb 10, 2013 at 11:12:11PM +0100, Hervé Poussineau wrote: >> >> Signed-off-by: Hervé Poussineau >> --- >> hw/ide/core.c |4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/hw/ide/core.c b/hw/ide/core.c >> index

Re: [Qemu-devel] [PATCH] ide: log error when trying to use ATAPI overlapping features

2013-02-11 Thread Stefan Hajnoczi
On Sun, Feb 10, 2013 at 11:12:11PM +0100, Hervé Poussineau wrote: > > Signed-off-by: Hervé Poussineau > --- > hw/ide/core.c |4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/hw/ide/core.c b/hw/ide/core.c > index 3743dc3..f0ab1a8 100644 > --- a/hw/ide/core.c > +++ b/

[Qemu-devel] [PATCH] ide: log error when trying to use ATAPI overlapping features

2013-02-10 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/ide/core.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index 3743dc3..f0ab1a8 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -1394,8 +1394,10 @@ void ide_exec_cmd(IDEBus *bus, uint32_t val)