Re: [Qemu-devel] [PATCH] ide: Check validity of logical block size

2014-12-03 Thread Kevin Wolf
Am 03.12.2014 um 13:35 hat Kevin Wolf geschrieben: > Our IDE emulation can't handle logical block sizes other than 512. Check > for it. > > The original assumption was that other values would silently be ignored > (which is bad enough), but it's not quite true: The physical block size > is exposed

Re: [Qemu-devel] [PATCH] ide: Check validity of logical block size

2014-12-03 Thread Kevin Wolf
Am 03.12.2014 um 15:37 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Our IDE emulation can't handle logical block sizes other than 512. Check > > for it. > > I guess this is in part due to the 512 literals sprinkled all over the > IDE code. Yes, this is one part. The other part

Re: [Qemu-devel] [PATCH] ide: Check validity of logical block size

2014-12-03 Thread John Snow
On 12/03/2014 07:35 AM, Kevin Wolf wrote: Our IDE emulation can't handle logical block sizes other than 512. Check for it. The original assumption was that other values would silently be ignored (which is bad enough), but it's not quite true: The physical block size is exposed in IDENTIFY DEVI

Re: [Qemu-devel] [PATCH] ide: Check validity of logical block size

2014-12-03 Thread Markus Armbruster
Kevin Wolf writes: > Our IDE emulation can't handle logical block sizes other than 512. Check > for it. I guess this is in part due to the 512 literals sprinkled all over the IDE code. > The original assumption was that other values would silently be ignored > (which is bad enough), but it's no

[Qemu-devel] [PATCH] ide: Check validity of logical block size

2014-12-03 Thread Kevin Wolf
Our IDE emulation can't handle logical block sizes other than 512. Check for it. The original assumption was that other values would silently be ignored (which is bad enough), but it's not quite true: The physical block size is exposed in IDENTIFY DEVICE as a multiple of the logical block size. Se