Re: [Qemu-devel] [PATCH] i440fx-test: remove ARRAY_SIZE redefinition

2015-04-28 Thread Michael Tokarev
Applied to -trivial, thanks! So much for removing one line :) /mjt

Re: [Qemu-devel] [PATCH] i440fx-test: remove ARRAY_SIZE redefinition

2015-04-27 Thread Paolo Bonzini
On 27/04/2015 00:04, Emilio G. Cota wrote: > It's defined in osdep.h and shouldn't be redefined here. > > Signed-off-by: Emilio G. Cota > --- > tests/i440fx-test.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/tests/i440fx-test.c b/tests/i440fx-test.c > index d0bc8de..33a7ecb 100644

Re: [Qemu-devel] [PATCH] i440fx-test: remove ARRAY_SIZE redefinition

2015-04-27 Thread Emilio G. Cota
On Sun, Apr 26, 2015 at 19:18:41 -0700, Peter Crosthwaite wrote: > On Sun, Apr 26, 2015 at 3:04 PM, Emilio G. Cota wrote: > > It's defined in osdep.h and shouldn't be redefined here. > > > > Signed-off-by: Emilio G. Cota > > > Reviewed-by: Peter Crosthwaite Thanks for having a look! > It loo

Re: [Qemu-devel] [PATCH] i440fx-test: remove ARRAY_SIZE redefinition

2015-04-26 Thread Peter Crosthwaite
On Sun, Apr 26, 2015 at 3:04 PM, Emilio G. Cota wrote: > It's defined in osdep.h and shouldn't be redefined here. > > Signed-off-by: Emilio G. Cota Reviewed-by: Peter Crosthwaite It looks like there may be another one too: hw/audio/fmopl.c:#define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))

[Qemu-devel] [PATCH] i440fx-test: remove ARRAY_SIZE redefinition

2015-04-26 Thread Emilio G. Cota
It's defined in osdep.h and shouldn't be redefined here. Signed-off-by: Emilio G. Cota --- tests/i440fx-test.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/i440fx-test.c b/tests/i440fx-test.c index d0bc8de..33a7ecb 100644 --- a/tests/i440fx-test.c +++ b/tests/i440fx-test.c @@ -27,8