Re: [Qemu-devel] [PATCH] i386: wire up MSR_IA32_MISC_ENABLE

2011-10-04 Thread Avi Kivity
On 10/04/2011 07:24 PM, Jan Kiszka wrote: >> >> Given that, when in conflict, we rather model after AMD than Intel for >> TCG, I would hesitate to expose this by default. Or are there >> precedences already? > > Practically all MSRs. i486 doesn't have any, IIRC, for example. Pre-Pentiums do

Re: [Qemu-devel] [PATCH] i386: wire up MSR_IA32_MISC_ENABLE

2011-10-04 Thread Jan Kiszka
On 2011-10-04 19:21, Avi Kivity wrote: > On 10/04/2011 07:14 PM, Jan Kiszka wrote: >> > >> >> > + >> >> > +static const VMStateDescription vmstate_msr_ia32_misc_enable = { >> >> > +.name = "cpu/msr_ia32_misc_enable", >> >> > +.version_id = 1, >> >> > +.minimum_version_id

Re: [Qemu-devel] [PATCH] i386: wire up MSR_IA32_MISC_ENABLE

2011-10-04 Thread Avi Kivity
On 10/04/2011 07:14 PM, Jan Kiszka wrote: > >> > + >> > +static const VMStateDescription vmstate_msr_ia32_misc_enable = { >> > +.name = "cpu/msr_ia32_misc_enable", >> > +.version_id = 1, >> > +.minimum_version_id = 1, >> > +.minimum_version_id_old = 1, >> > +

Re: [Qemu-devel] [PATCH] i386: wire up MSR_IA32_MISC_ENABLE

2011-10-04 Thread Jan Kiszka
On 2011-10-04 19:08, Avi Kivity wrote: > On 10/04/2011 06:05 PM, Jan Kiszka wrote: >> On 2011-10-04 16:26, Avi Kivity wrote: >> > It's needed for its default value - bit 0 specifies that "rep movs" is >> > good enough for memcpy, and Linux may use a slower memcpu if it is >> not set, >> > depend

Re: [Qemu-devel] [PATCH] i386: wire up MSR_IA32_MISC_ENABLE

2011-10-04 Thread Avi Kivity
On 10/04/2011 06:05 PM, Jan Kiszka wrote: On 2011-10-04 16:26, Avi Kivity wrote: > It's needed for its default value - bit 0 specifies that "rep movs" is > good enough for memcpy, and Linux may use a slower memcpu if it is not set, > depending on cpu family/model. > > Signed-off-by: Avi Kivit

Re: [Qemu-devel] [PATCH] i386: wire up MSR_IA32_MISC_ENABLE

2011-10-04 Thread Jan Kiszka
On 2011-10-04 16:26, Avi Kivity wrote: > It's needed for its default value - bit 0 specifies that "rep movs" is > good enough for memcpy, and Linux may use a slower memcpu if it is not set, > depending on cpu family/model. > > Signed-off-by: Avi Kivity > --- > target-i386/cpu.h |5

[Qemu-devel] [PATCH] i386: wire up MSR_IA32_MISC_ENABLE

2011-10-04 Thread Avi Kivity
It's needed for its default value - bit 0 specifies that "rep movs" is good enough for memcpy, and Linux may use a slower memcpu if it is not set, depending on cpu family/model. Signed-off-by: Avi Kivity --- target-i386/cpu.h |5 + target-i386/helper.c|1 + target-i386/kvm.