Re: [Qemu-devel] [PATCH] i386: Allow cpuid bit override

2017-04-13 Thread Eduardo Habkost
On Tue, Mar 28, 2017 at 09:31:05AM -0300, Eduardo Habkost wrote: > On Tue, Mar 28, 2017 at 01:26:04PM +0200, Alexander Graf wrote: > > On 03/28/2017 02:41 AM, Eduardo Habkost wrote: > > > On Tue, Mar 28, 2017 at 12:19:37AM +0200, Alexander Graf wrote: > > > > KVM has a feature bitmap of CPUID bits

Re: [Qemu-devel] [PATCH] i386: Allow cpuid bit override

2017-03-30 Thread Alexander Graf
On 03/30/2017 04:25 PM, Eduardo Habkost wrote: On Thu, Mar 30, 2017 at 04:23:34PM +0200, Alexander Graf wrote: On 03/30/2017 04:22 PM, Eduardo Habkost wrote: On Tue, Mar 28, 2017 at 02:35:57PM +0200, Alexander Graf wrote: On 03/28/2017 02:31 PM, Eduardo Habkost wrote: On Tue, Mar 28, 2017 at

Re: [Qemu-devel] [PATCH] i386: Allow cpuid bit override

2017-03-30 Thread Eduardo Habkost
On Thu, Mar 30, 2017 at 04:23:34PM +0200, Alexander Graf wrote: > On 03/30/2017 04:22 PM, Eduardo Habkost wrote: > > On Tue, Mar 28, 2017 at 02:35:57PM +0200, Alexander Graf wrote: > > > On 03/28/2017 02:31 PM, Eduardo Habkost wrote: > > > > On Tue, Mar 28, 2017 at 01:26:04PM +0200, Alexander Graf

Re: [Qemu-devel] [PATCH] i386: Allow cpuid bit override

2017-03-30 Thread Eduardo Habkost
On Tue, Mar 28, 2017 at 02:35:57PM +0200, Alexander Graf wrote: > On 03/28/2017 02:31 PM, Eduardo Habkost wrote: > > On Tue, Mar 28, 2017 at 01:26:04PM +0200, Alexander Graf wrote: [...] > > > Putting it into a special enum sounds much more fragile than the current > > > solution to me. We need to

Re: [Qemu-devel] [PATCH] i386: Allow cpuid bit override

2017-03-30 Thread Alexander Graf
On 03/30/2017 04:22 PM, Eduardo Habkost wrote: On Tue, Mar 28, 2017 at 02:35:57PM +0200, Alexander Graf wrote: On 03/28/2017 02:31 PM, Eduardo Habkost wrote: On Tue, Mar 28, 2017 at 01:26:04PM +0200, Alexander Graf wrote: [...] Putting it into a special enum sounds much more fragile than the

Re: [Qemu-devel] [PATCH] i386: Allow cpuid bit override

2017-03-28 Thread Paolo Bonzini
On 28/03/2017 18:01, Eduardo Habkost wrote: >> Using an on/off/force enum sounds like the right thing to do. >> >> However, I would open code the getters and setters completely (using >> visit_type_str) instead of using visit_type_FooEnum+visit_type_bool. >> Then you can easily map yes/true to on

Re: [Qemu-devel] [PATCH] i386: Allow cpuid bit override

2017-03-28 Thread Eduardo Habkost
On Tue, Mar 28, 2017 at 02:41:55PM +0200, Paolo Bonzini wrote: > > > On 28/03/2017 13:26, Alexander Graf wrote: > >> You can define an enum type in qapi-schema.json, and use > >> visit_type_(). You can grep for > >> visit_type_OnOffAuto to find examples. > >> > >> (But I suggest naming the enum s

Re: [Qemu-devel] [PATCH] i386: Allow cpuid bit override

2017-03-28 Thread Paolo Bonzini
On 28/03/2017 13:26, Alexander Graf wrote: >> You can define an enum type in qapi-schema.json, and use >> visit_type_(). You can grep for >> visit_type_OnOffAuto to find examples. >> >> (But I suggest naming the enum something like >> "X86CPUFeatureSetting" instead of "OnOffForce", because we wil

Re: [Qemu-devel] [PATCH] i386: Allow cpuid bit override

2017-03-28 Thread Alexander Graf
On 03/28/2017 02:31 PM, Eduardo Habkost wrote: On Tue, Mar 28, 2017 at 01:26:04PM +0200, Alexander Graf wrote: On 03/28/2017 02:41 AM, Eduardo Habkost wrote: On Tue, Mar 28, 2017 at 12:19:37AM +0200, Alexander Graf wrote: KVM has a feature bitmap of CPUID bits that it knows works for guests. Q

Re: [Qemu-devel] [PATCH] i386: Allow cpuid bit override

2017-03-28 Thread Eduardo Habkost
On Tue, Mar 28, 2017 at 01:26:04PM +0200, Alexander Graf wrote: > On 03/28/2017 02:41 AM, Eduardo Habkost wrote: > > On Tue, Mar 28, 2017 at 12:19:37AM +0200, Alexander Graf wrote: > > > KVM has a feature bitmap of CPUID bits that it knows works for guests. > > > QEMU removes bits that are not part

Re: [Qemu-devel] [PATCH] i386: Allow cpuid bit override

2017-03-28 Thread Alexander Graf
On 03/28/2017 02:41 AM, Eduardo Habkost wrote: On Tue, Mar 28, 2017 at 12:19:37AM +0200, Alexander Graf wrote: KVM has a feature bitmap of CPUID bits that it knows works for guests. QEMU removes bits that are not part of that bitmap automatically on VM start. However, some times we just don't l

Re: [Qemu-devel] [PATCH] i386: Allow cpuid bit override

2017-03-27 Thread Eduardo Habkost
On Tue, Mar 28, 2017 at 12:19:37AM +0200, Alexander Graf wrote: > KVM has a feature bitmap of CPUID bits that it knows works for guests. > QEMU removes bits that are not part of that bitmap automatically on VM > start. > > However, some times we just don't list features in that list because > they

[Qemu-devel] [PATCH] i386: Allow cpuid bit override

2017-03-27 Thread Alexander Graf
KVM has a feature bitmap of CPUID bits that it knows works for guests. QEMU removes bits that are not part of that bitmap automatically on VM start. However, some times we just don't list features in that list because they don't make sense for normal scenarios, but may be useful in specific, targe