Re: [Qemu-devel] [PATCH] i386/kvm: Do not sync nested state during runtime

2019-07-22 Thread Paolo Bonzini
On 22/07/19 12:43, Jan Kiszka wrote: >> Currently QEMU writes to userspace maintained nested-state only at >> kvm_arch_init_vcpu() and >> when loading vmstate_nested_state vmstate subsection. >> kvm_arch_reset_vcpu() do not modify userspace maintained nested-state. > Hmm, then we probably achieve

Re: [Qemu-devel] [PATCH] i386/kvm: Do not sync nested state during runtime

2019-07-22 Thread Jan Kiszka
On 22.07.19 12:31, Liran Alon wrote: >> On 22 Jul 2019, at 13:20, Jan Kiszka wrote: >> >> On 22.07.19 11:44, Liran Alon wrote: >>> >>> On 22 Jul 2019, at 7:00, Jan Kiszka wrote: Writing the nested state e.g. after a vmport access can invalidate important parts of the kernel-in

Re: [Qemu-devel] [PATCH] i386/kvm: Do not sync nested state during runtime

2019-07-22 Thread Liran Alon
> On 22 Jul 2019, at 13:20, Jan Kiszka wrote: > > On 22.07.19 11:44, Liran Alon wrote: >> >> >>> On 22 Jul 2019, at 7:00, Jan Kiszka wrote: >>> >>> Writing the nested state e.g. after a vmport access can invalidate >>> important parts of the kernel-internal state, and it is not needed as >

Re: [Qemu-devel] [PATCH] i386/kvm: Do not sync nested state during runtime

2019-07-22 Thread Jan Kiszka
On 22.07.19 11:44, Liran Alon wrote: > > >> On 22 Jul 2019, at 7:00, Jan Kiszka wrote: >> >> Writing the nested state e.g. after a vmport access can invalidate >> important parts of the kernel-internal state, and it is not needed as >> well. So leave this out from KVM_PUT_RUNTIME_STATE. >> >> Su

Re: [Qemu-devel] [PATCH] i386/kvm: Do not sync nested state during runtime

2019-07-22 Thread Liran Alon
> On 22 Jul 2019, at 7:00, Jan Kiszka wrote: > > Writing the nested state e.g. after a vmport access can invalidate > important parts of the kernel-internal state, and it is not needed as > well. So leave this out from KVM_PUT_RUNTIME_STATE. > > Suggested-by: Paolo Bonzini > Signed-off-by: J

[Qemu-devel] [PATCH] i386/kvm: Do not sync nested state during runtime

2019-07-21 Thread Jan Kiszka
Writing the nested state e.g. after a vmport access can invalidate important parts of the kernel-internal state, and it is not needed as well. So leave this out from KVM_PUT_RUNTIME_STATE. Suggested-by: Paolo Bonzini Signed-off-by: Jan Kiszka --- target/i386/kvm.c | 10 +- 1 file change