Re: [Qemu-devel] [PATCH] i.MX: Improve EPIT timer code.

2013-05-27 Thread Peter Chubb
Hi Jean, Thanks for this. Most of it appears cosmetic and an improvement. Comments in-line below. > > /* > * Update interrupt status > */ > -static void imx_timerp_update(IMXTimerPState *s) > +static void imx_timer_epit_update(IMXTimerEPITState *s) > { > -if (s->sr && (s->cr & C

[Qemu-devel] [PATCH] i.MX: Improve EPIT timer code.

2013-05-27 Thread Jean-Christophe DUBOIS
* Unify function and type naming * use dynamic cast whenever possible * simplify Debug printf. * use new style device intialization. Signed-off-by: Jean-Christophe DUBOIS --- hw/timer/imx_epit.c | 227 +--- 1 file changed, 129 insertions(+), 98 del