On Thu Apr 07, 2011 at 14:52:34 +0100, Stefan Hajnoczi wrote:
> On Thu, Apr 7, 2011 at 1:56 PM, Ralf Ramsauer
> wrote:
> > On 07.04.2011, at 14:48, Stefan Hajnoczi wrote:
> >
> >> Out of curiousity, why are you trying to kill spaces at all?
> >>
> >> Why not just use a correct command-line to inv
On Thu, Apr 7, 2011 at 1:56 PM, Ralf Ramsauer
wrote:
> On 07.04.2011, at 14:48, Stefan Hajnoczi wrote:
>
>> Out of curiousity, why are you trying to kill spaces at all?
>>
>> Why not just use a correct command-line to invoke QEMU?
>>
>> Stefan
>
> Well it took me 2 days to find out why -initrd "mo
On 07.04.2011, at 14:48, Stefan Hajnoczi wrote:
> Out of curiousity, why are you trying to kill spaces at all?
>
> Why not just use a correct command-line to invoke QEMU?
>
> Stefan
Well it took me 2 days to find out why -initrd "module1, module2" didn't work.
If there's a space after the comm
Out of curiousity, why are you trying to kill spaces at all?
Why not just use a correct command-line to invoke QEMU?
Stefan
Hello again,
there's another problem with parsing the initrd string:
If you want to start qemu with ... -initrd "mod1 arg=foo,bar , mod2
arg=bar,foo" it won't work
The string is separated at every comma, arguments containing a comma are
misinterpreted.
So we'd think about another way deliverin
On 07.04.2011, at 14:07, Ralf Ramsauer wrote:
> On 07.04.2011 um 10:38, Alexander Graf wrote:
>>
>> Also, I just realized that you did miss another small part that needs
>> change. A few lines above, there is code to interpret the modules right
>> before that as well:
>>
>> if (initrd_filen
On 07.04.2011 um 10:38, Alexander Graf wrote:
>
> Also, I just realized that you did miss another small part that needs change.
> A few lines above, there is code to interpret the modules right before that
> as well:
>
>if (initrd_filename) {
>const char *r = initrd_filename;
>
Leading spaces mustn't be stripped! The commandline could look like:
qemu -kernel kern -initrd "1.mod arg=foo arg2=bar, 2.mod arg=asdf"
The problem is, that the string
"1.mod arg=foo arg2=bar, 2.mod arg=asdf"
is divided at the ','. So we have two string
"1.mod arg=foo arg2=bar" and
" 2.mod arg=asdf
On Thu, Apr 07, 2011 at 12:19:01AM -, r...@humppa.name wrote:
> @@ -267,6 +267,9 @@ int load_multiboot(void *fw_cfg,
> /* if a space comes after the module filename, treat everything
> after that as parameters */
> target_phys_addr_t c = mb_add_cmdline(
On 07.04.2011, at 07:56, Ralf Ramsauer wrote:
> Here the version with the correct coding style.
Phew - please keep the commit message intact. What we do to apply patches is
that we simply directly take your patch into git using "git am". With a patch
description like this, if anyone looks at "
Here the version with the correct coding style.
diff --git a/hw/multiboot.c b/hw/multiboot.c
index 0d2bfb4..2380d5e 100644
--- a/hw/multiboot.c
+++ b/hw/multiboot.c
@@ -267,6 +267,11 @@ int load_multiboot(void *fw_cfg,
/* if a space comes after the module filename, treat everything
On Thu, 7 Apr 2011 10:19:01 am r...@humppa.name wrote:
> Signed-off-by:
Looks like something may be wrong with your git config
Brad
On 07.04.2011, at 02:19, r...@humppa.name wrote:
> Multiboot modules couldn't be loaded when there are spaces between the
> filename and ','. Those spaces can simply be killed.
>
> Signed-off-by:
> ---
> diff --git a/hw/multiboot.c b/hw/multiboot.c
> index 0d2bfb4..27eb159 100644
> --- a/hw/mult
Multiboot modules couldn't be loaded when there are spaces between the
filename and ','. Those spaces can simply be killed.
Signed-off-by:
---
diff --git a/hw/multiboot.c b/hw/multiboot.c
index 0d2bfb4..27eb159 100644
--- a/hw/multiboot.c
+++ b/hw/multiboot.c
@@ -267,6 +267,9 @@ int load_multiboot
14 matches
Mail list logo
