Re: [Qemu-devel] [PATCH] hw/wm8750: Fix potential buffer overflow

2012-09-10 Thread Aurelien Jarno
On Mon, Sep 03, 2012 at 10:56:00PM +0200, Stefan Weil wrote: > Report from smatch: > > hw/wm8750.c:369 wm8750_tx(12) error: buffer overflow 's->i2c_data' 2 <= 2 > > It looks like the preprocessor statements were simply misplaced. > > Replace also __FUNCTION__ by __func__ to please checkpatch.pl.

Re: [Qemu-devel] [PATCH] hw/wm8750: Fix potential buffer overflow

2012-09-03 Thread Peter Maydell
On 3 September 2012 21:56, Stefan Weil wrote: > Report from smatch: > > hw/wm8750.c:369 wm8750_tx(12) error: buffer overflow 's->i2c_data' 2 <= 2 > > It looks like the preprocessor statements were simply misplaced. > > Replace also __FUNCTION__ by __func__ to please checkpatch.pl. > > Signed-off-b

[Qemu-devel] [PATCH] hw/wm8750: Fix potential buffer overflow

2012-09-03 Thread Stefan Weil
Report from smatch: hw/wm8750.c:369 wm8750_tx(12) error: buffer overflow 's->i2c_data' 2 <= 2 It looks like the preprocessor statements were simply misplaced. Replace also __FUNCTION__ by __func__ to please checkpatch.pl. Signed-off-by: Stefan Weil --- hw/wm8750.c |4 ++-- 1 file changed,