Re: [Qemu-devel] [PATCH] hw/virtio/balloon: Fixes for different host page sizes

2016-05-22 Thread Jitendra Kolhe
On 4/13/2016 8:21 PM, Thomas Huth wrote: > On 13.04.2016 15:15, Michael S. Tsirkin wrote: >> On Wed, Apr 13, 2016 at 01:52:44PM +0200, Thomas Huth wrote: >>> The balloon code currently calls madvise() with TARGET_PAGE_SIZE >>> as length parameter, and an address which is directly based on >>> the p

Re: [Qemu-devel] [PATCH] hw/virtio/balloon: Fixes for different host page sizes

2016-04-14 Thread David Gibson
On Thu, 14 Apr 2016 19:34:05 +0100 "Dr. David Alan Gilbert" wrote: > * Thomas Huth (th...@redhat.com) wrote: > > On 14.04.2016 13:47, Dr. David Alan Gilbert wrote: > > > * Thomas Huth (th...@redhat.com) wrote: > > > > > >> That would mean a regression compared to what we have today. Currentl

Re: [Qemu-devel] [PATCH] hw/virtio/balloon: Fixes for different host page sizes

2016-04-14 Thread Dr. David Alan Gilbert
* Thomas Huth (th...@redhat.com) wrote: > On 14.04.2016 13:47, Dr. David Alan Gilbert wrote: > > * Thomas Huth (th...@redhat.com) wrote: > > > >> That would mean a regression compared to what we have today. Currently, > >> the ballooning is working OK for 64k guests on a 64k ppc host - rather > >>

Re: [Qemu-devel] [PATCH] hw/virtio/balloon: Fixes for different host page sizes

2016-04-14 Thread Thomas Huth
On 14.04.2016 13:47, Dr. David Alan Gilbert wrote: > * Thomas Huth (th...@redhat.com) wrote: > >> That would mean a regression compared to what we have today. Currently, >> the ballooning is working OK for 64k guests on a 64k ppc host - rather >> by chance than on purpose, but it's working. The gu

Re: [Qemu-devel] [PATCH] hw/virtio/balloon: Fixes for different host page sizes

2016-04-14 Thread Dr. David Alan Gilbert
* Thomas Huth (th...@redhat.com) wrote: > That would mean a regression compared to what we have today. Currently, > the ballooning is working OK for 64k guests on a 64k ppc host - rather > by chance than on purpose, but it's working. The guest is always sending > all the 4k fragments of a 64k page

Re: [Qemu-devel] [PATCH] hw/virtio/balloon: Fixes for different host page sizes

2016-04-13 Thread David Gibson
On Wed, 13 Apr 2016 21:14:44 +0300 "Michael S. Tsirkin" wrote: > On Wed, Apr 13, 2016 at 08:11:36PM +0200, Thomas Huth wrote: > > On 13.04.2016 19:55, Michael S. Tsirkin wrote: > > > On Wed, Apr 13, 2016 at 07:38:12PM +0200, Thomas Huth wrote: > > >> On 13.04.2016 19:07, Michael S. Tsirkin wr

Re: [Qemu-devel] [PATCH] hw/virtio/balloon: Fixes for different host page sizes

2016-04-13 Thread David Gibson
On Wed, 13 Apr 2016 16:15:25 +0300 "Michael S. Tsirkin" wrote: > On Wed, Apr 13, 2016 at 01:52:44PM +0200, Thomas Huth wrote: > > The balloon code currently calls madvise() with TARGET_PAGE_SIZE > > as length parameter, and an address which is directly based on > > the page address supplied by th

Re: [Qemu-devel] [PATCH] hw/virtio/balloon: Fixes for different host page sizes

2016-04-13 Thread David Gibson
On Wed, 13 Apr 2016 13:52:44 +0200 Thomas Huth wrote: > The balloon code currently calls madvise() with TARGET_PAGE_SIZE > as length parameter, and an address which is directly based on > the page address supplied by the guest. Since the virtio-balloon > protocol is always based on 4k based addre

Re: [Qemu-devel] [PATCH] hw/virtio/balloon: Fixes for different host page sizes

2016-04-13 Thread Andrew Jones
On Wed, Apr 13, 2016 at 08:11:36PM +0200, Thomas Huth wrote: > On 13.04.2016 19:55, Michael S. Tsirkin wrote: > > On Wed, Apr 13, 2016 at 07:38:12PM +0200, Thomas Huth wrote: > >> On 13.04.2016 19:07, Michael S. Tsirkin wrote: > >>> On Wed, Apr 13, 2016 at 04:51:49PM +0200, Thomas Huth wrote: > >>>

Re: [Qemu-devel] [PATCH] hw/virtio/balloon: Fixes for different host page sizes

2016-04-13 Thread Michael S. Tsirkin
On Wed, Apr 13, 2016 at 08:11:36PM +0200, Thomas Huth wrote: > On 13.04.2016 19:55, Michael S. Tsirkin wrote: > > On Wed, Apr 13, 2016 at 07:38:12PM +0200, Thomas Huth wrote: > >> On 13.04.2016 19:07, Michael S. Tsirkin wrote: > >>> On Wed, Apr 13, 2016 at 04:51:49PM +0200, Thomas Huth wrote: > >>>

Re: [Qemu-devel] [PATCH] hw/virtio/balloon: Fixes for different host page sizes

2016-04-13 Thread Thomas Huth
On 13.04.2016 19:55, Michael S. Tsirkin wrote: > On Wed, Apr 13, 2016 at 07:38:12PM +0200, Thomas Huth wrote: >> On 13.04.2016 19:07, Michael S. Tsirkin wrote: >>> On Wed, Apr 13, 2016 at 04:51:49PM +0200, Thomas Huth wrote: On 13.04.2016 15:15, Michael S. Tsirkin wrote: > On Wed, Apr 13,

Re: [Qemu-devel] [PATCH] hw/virtio/balloon: Fixes for different host page sizes

2016-04-13 Thread Thomas Huth
On 13.04.2016 19:07, Michael S. Tsirkin wrote: > On Wed, Apr 13, 2016 at 04:51:49PM +0200, Thomas Huth wrote: >> On 13.04.2016 15:15, Michael S. Tsirkin wrote: >>> On Wed, Apr 13, 2016 at 01:52:44PM +0200, Thomas Huth wrote: ... Then, there's yet another problem: If the host page size is bigge

Re: [Qemu-devel] [PATCH] hw/virtio/balloon: Fixes for different host page sizes

2016-04-13 Thread Michael S. Tsirkin
On Wed, Apr 13, 2016 at 07:38:12PM +0200, Thomas Huth wrote: > On 13.04.2016 19:07, Michael S. Tsirkin wrote: > > On Wed, Apr 13, 2016 at 04:51:49PM +0200, Thomas Huth wrote: > >> On 13.04.2016 15:15, Michael S. Tsirkin wrote: > >>> On Wed, Apr 13, 2016 at 01:52:44PM +0200, Thomas Huth wrote: > ...

Re: [Qemu-devel] [PATCH] hw/virtio/balloon: Fixes for different host page sizes

2016-04-13 Thread Michael S. Tsirkin
On Wed, Apr 13, 2016 at 04:51:49PM +0200, Thomas Huth wrote: > On 13.04.2016 15:15, Michael S. Tsirkin wrote: > > On Wed, Apr 13, 2016 at 01:52:44PM +0200, Thomas Huth wrote: > >> The balloon code currently calls madvise() with TARGET_PAGE_SIZE > >> as length parameter, and an address which is dire

Re: [Qemu-devel] [PATCH] hw/virtio/balloon: Fixes for different host page sizes

2016-04-13 Thread Thomas Huth
On 13.04.2016 15:15, Michael S. Tsirkin wrote: > On Wed, Apr 13, 2016 at 01:52:44PM +0200, Thomas Huth wrote: >> The balloon code currently calls madvise() with TARGET_PAGE_SIZE >> as length parameter, and an address which is directly based on >> the page address supplied by the guest. Since the vi

Re: [Qemu-devel] [PATCH] hw/virtio/balloon: Fixes for different host page sizes

2016-04-13 Thread Michael S. Tsirkin
On Wed, Apr 13, 2016 at 01:52:44PM +0200, Thomas Huth wrote: > The balloon code currently calls madvise() with TARGET_PAGE_SIZE > as length parameter, and an address which is directly based on > the page address supplied by the guest. Since the virtio-balloon > protocol is always based on 4k based

Re: [Qemu-devel] [PATCH] hw/virtio/balloon: Fixes for different host page sizes

2016-04-13 Thread Andrew Jones
On Wed, Apr 13, 2016 at 01:52:44PM +0200, Thomas Huth wrote: > The balloon code currently calls madvise() with TARGET_PAGE_SIZE > as length parameter, and an address which is directly based on > the page address supplied by the guest. Since the virtio-balloon > protocol is always based on 4k based

[Qemu-devel] [PATCH] hw/virtio/balloon: Fixes for different host page sizes

2016-04-13 Thread Thomas Huth
The balloon code currently calls madvise() with TARGET_PAGE_SIZE as length parameter, and an address which is directly based on the page address supplied by the guest. Since the virtio-balloon protocol is always based on 4k based addresses/sizes, no matter what the host and guest are using as page