Re: [Qemu-devel] [PATCH] hw/sd/sdcard: Use the available enums

2019-05-07 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > Philippe Mathieu-Daudé writes: > > > We already define SDCardModes/SDCardStates as enums. Declare > > the mode/state as enums too, this make gdb debugging sessions > > friendlier: instead of numbers, the mode/state name is displayed. > > > > Signed

Re: [Qemu-devel] [PATCH] hw/sd/sdcard: Use the available enums

2019-05-06 Thread Philippe Mathieu-Daudé
On 5/6/19 10:55 AM, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > >> We already define SDCardModes/SDCardStates as enums. Declare >> the mode/state as enums too, this make gdb debugging sessions >> friendlier: instead of numbers, the mode/state name is displayed. >> >> Signed-off-by

Re: [Qemu-devel] [PATCH] hw/sd/sdcard: Use the available enums

2019-05-06 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > We already define SDCardModes/SDCardStates as enums. Declare > the mode/state as enums too, this make gdb debugging sessions > friendlier: instead of numbers, the mode/state name is displayed. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/sd/sd.c | 6 +++-

[Qemu-devel] [PATCH] hw/sd/sdcard: Use the available enums

2019-05-05 Thread Philippe Mathieu-Daudé
We already define SDCardModes/SDCardStates as enums. Declare the mode/state as enums too, this make gdb debugging sessions friendlier: instead of numbers, the mode/state name is displayed. Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletio