Re: [Qemu-devel] [PATCH] hw/s390x: fix clang compilation on 32bit machines

2019-03-18 Thread Philippe Mathieu-Daudé
Le lun. 18 mars 2019 11:34, Marcel Apfelbaum a écrit : > Hi Christian, > > On 3/18/19 11:27 AM, Christian Borntraeger wrote: > > > > On 16.03.19 12:09, Philippe Mathieu-Daudé wrote: > >> Hi Marcel, > >> > >> On 3/16/19 10:50 AM, Marcel Apfelbaum wrote: > >>> Configuring QEMU with: > >>> conf

Re: [Qemu-devel] [PATCH] hw/s390x: fix clang compilation on 32bit machines

2019-03-18 Thread Marcel Apfelbaum
Hi Christian, On 3/18/19 11:27 AM, Christian Borntraeger wrote: On 16.03.19 12:09, Philippe Mathieu-Daudé wrote: Hi Marcel, On 3/16/19 10:50 AM, Marcel Apfelbaum wrote: Configuring QEMU with: configure --cc=clang --target-list=s390x-softmmu And compiling it using a 32 bit machine leads

Re: [Qemu-devel] [PATCH] hw/s390x: fix clang compilation on 32bit machines

2019-03-18 Thread Christian Borntraeger
On 16.03.19 12:09, Philippe Mathieu-Daudé wrote: > Hi Marcel, > > On 3/16/19 10:50 AM, Marcel Apfelbaum wrote: >> Configuring QEMU with: >> configure --cc=clang --target-list=s390x-softmmu >> And compiling it using a 32 bit machine leads to: > > Because there sizeof(ram_addr_t) = sizeof(ui

Re: [Qemu-devel] [PATCH] hw/s390x: fix clang compilation on 32bit machines

2019-03-16 Thread Marcel Apfelbaum
Hi Philippe, On 3/16/19 1:09 PM, Philippe Mathieu-Daudé wrote: Hi Marcel, On 3/16/19 10:50 AM, Marcel Apfelbaum wrote: Configuring QEMU with: configure --cc=clang --target-list=s390x-softmmu And compiling it using a 32 bit machine leads to: Because there sizeof(ram_addr_t) = sizeof(uintp

Re: [Qemu-devel] [PATCH] hw/s390x: fix clang compilation on 32bit machines

2019-03-16 Thread Philippe Mathieu-Daudé
Hi Marcel, On 3/16/19 10:50 AM, Marcel Apfelbaum wrote: > Configuring QEMU with: > configure --cc=clang --target-list=s390x-softmmu > And compiling it using a 32 bit machine leads to: Because there sizeof(ram_addr_t) = sizeof(uintptr_t) = 32. > hw/s390x/s390-virtio-ccw.c:175:27: error: i

[Qemu-devel] [PATCH] hw/s390x: fix clang compilation on 32bit machines

2019-03-16 Thread Marcel Apfelbaum
Configuring QEMU with: configure --cc=clang --target-list=s390x-softmmu And compiling it using a 32 bit machine leads to: hw/s390x/s390-virtio-ccw.c:175:27: error: implicit conversion from 'unsigned long long' to 'ram_addr_t' (aka 'unsigned int') changes value from 8796091973632