Re: [Qemu-devel] [PATCH] hw/s390x: Fix the function arguments in the pci stub file

2019-02-11 Thread Cornelia Huck
On Mon, 11 Feb 2019 12:17:26 +0100 Thomas Huth wrote: > On 2019-02-11 12:04, Cornelia Huck wrote: > > On Mon, 11 Feb 2019 11:54:45 +0100 > > Thomas Huth wrote: > > > >> On 2019-02-11 11:48, Cornelia Huck wrote: > >>> On Fri, 1 Feb 2019 09:23:56 +0100 > >>> Cornelia Huck wrote: > >>> >

Re: [Qemu-devel] [PATCH] hw/s390x: Fix the function arguments in the pci stub file

2019-02-11 Thread Thomas Huth
On 2019-02-11 12:04, Cornelia Huck wrote: > On Mon, 11 Feb 2019 11:54:45 +0100 > Thomas Huth wrote: > >> On 2019-02-11 11:48, Cornelia Huck wrote: >>> On Fri, 1 Feb 2019 09:23:56 +0100 >>> Cornelia Huck wrote: >>> On Fri, 1 Feb 2019 07:46:40 +0100 Thomas Huth wrote: >>> >

Re: [Qemu-devel] [PATCH] hw/s390x: Fix the function arguments in the pci stub file

2019-02-11 Thread Cornelia Huck
On Mon, 11 Feb 2019 11:54:45 +0100 Thomas Huth wrote: > On 2019-02-11 11:48, Cornelia Huck wrote: > > On Fri, 1 Feb 2019 09:23:56 +0100 > > Cornelia Huck wrote: > > > >> On Fri, 1 Feb 2019 07:46:40 +0100 > >> Thomas Huth wrote: > > > >>> So I see two options now: > >>> > >>> 1) Finally

Re: [Qemu-devel] [PATCH] hw/s390x: Fix the function arguments in the pci stub file

2019-02-11 Thread Thomas Huth
On 2019-02-11 11:48, Cornelia Huck wrote: > On Fri, 1 Feb 2019 09:23:56 +0100 > Cornelia Huck wrote: > >> On Fri, 1 Feb 2019 07:46:40 +0100 >> Thomas Huth wrote: > >>> So I see two options now: >>> >>> 1) Finally really make the device optional, at least for new machine >>> types, so we can rea

Re: [Qemu-devel] [PATCH] hw/s390x: Fix the function arguments in the pci stub file

2019-02-11 Thread Cornelia Huck
On Fri, 1 Feb 2019 09:23:56 +0100 Cornelia Huck wrote: > On Fri, 1 Feb 2019 07:46:40 +0100 > Thomas Huth wrote: > > So I see two options now: > > > > 1) Finally really make the device optional, at least for new machine > > types, so we can really disable CONFIG_PCI and get a working executable

Re: [Qemu-devel] [PATCH] hw/s390x: Fix the function arguments in the pci stub file

2019-02-01 Thread Cornelia Huck
On Fri, 1 Feb 2019 07:46:40 +0100 Thomas Huth wrote: > On 2019-02-01 07:14, Thomas Huth wrote: > > On 2019-01-31 19:08, Paolo Bonzini wrote: > >> On 31/01/19 19:00, Thomas Huth wrote: > > (and the prototypes in the header) anymore, so if you try to compile > > s390x > > without C

Re: [Qemu-devel] [PATCH] hw/s390x: Fix the function arguments in the pci stub file

2019-01-31 Thread Thomas Huth
On 2019-02-01 07:14, Thomas Huth wrote: > On 2019-01-31 19:08, Paolo Bonzini wrote: >> On 31/01/19 19:00, Thomas Huth wrote: > (and the prototypes in the header) anymore, so if you try to compile s390x > without CONFIG_PCI, the build currently fails. > Fixes: 468a93898a97 ("s390x/p

Re: [Qemu-devel] [PATCH] hw/s390x: Fix the function arguments in the pci stub file

2019-01-31 Thread Thomas Huth
On 2019-01-31 19:08, Paolo Bonzini wrote: > On 31/01/19 19:00, Thomas Huth wrote: (and the prototypes in the header) anymore, so if you try to compile s390x without CONFIG_PCI, the build currently fails. >>> Fixes: 468a93898a97 ("s390x/pci: pass the retaddr to all PCI instructions")

Re: [Qemu-devel] [PATCH] hw/s390x: Fix the function arguments in the pci stub file

2019-01-31 Thread Paolo Bonzini
On 31/01/19 19:00, Thomas Huth wrote: >>> (and the prototypes in the header) anymore, so if you try to compile s390x >>> without CONFIG_PCI, the build currently fails. >>> >> Fixes: 468a93898a97 ("s390x/pci: pass the retaddr to all PCI instructions") >> >>> Signed-off-by: Thomas Huth >>> --- >>>

Re: [Qemu-devel] [PATCH] hw/s390x: Fix the function arguments in the pci stub file

2019-01-31 Thread Cornelia Huck
On Thu, 31 Jan 2019 18:47:08 +0100 Thomas Huth wrote: > The arguments of the stub functions to not match the real implementation s/to/do/ > (and the prototypes in the header) anymore, so if you try to compile s390x > without CONFIG_PCI, the build currently fails. > Fixes: 468a93898a97 ("s390x

Re: [Qemu-devel] [PATCH] hw/s390x: Fix the function arguments in the pci stub file

2019-01-31 Thread Thomas Huth
On 2019-01-31 18:56, Cornelia Huck wrote: > On Thu, 31 Jan 2019 18:47:08 +0100 > Thomas Huth wrote: > >> The arguments of the stub functions to not match the real implementation > > s/to/do/ D'oh! >> (and the prototypes in the header) anymore, so if you try to compile s390x >> without CONFIG_P

[Qemu-devel] [PATCH] hw/s390x: Fix the function arguments in the pci stub file

2019-01-31 Thread Thomas Huth
The arguments of the stub functions to not match the real implementation (and the prototypes in the header) anymore, so if you try to compile s390x without CONFIG_PCI, the build currently fails. Signed-off-by: Thomas Huth --- hw/s390x/s390-pci-stub.c | 16 +--- 1 file changed, 9 inse