Re: [Qemu-devel] [PATCH] hw/qxl: warn on sync io usage

2012-10-11 Thread Alon Levy
> Hi, > > > +static void sync_io_warning(PCIQXLDevice *qxl, uint32_t io_port) > > +{ > > +fprintf(stderr, "qxl-%d: WARNING: sync io used, see (RHBZ > > 747011)", > > +qxl->id); > > +fprintf(stderr, "qxl-%d: WARNING: virt-viewer/remote-viewer > > can hang\n", > > +qx

Re: [Qemu-devel] [PATCH] hw/qxl: warn on sync io usage

2012-10-10 Thread Gerd Hoffmann
Hi, > +static void sync_io_warning(PCIQXLDevice *qxl, uint32_t io_port) > +{ > +fprintf(stderr, "qxl-%d: WARNING: sync io used, see (RHBZ 747011)", > +qxl->id); > +fprintf(stderr, "qxl-%d: WARNING: virt-viewer/remote-viewer can hang\n", > +qxl->id); > +if (qxl

[Qemu-devel] [PATCH] hw/qxl: warn on sync io usage

2012-10-10 Thread Alon Levy
Signed-off-by: Alon Levy --- Try to warn people who keep getting bitten by this. In addition maybe we should bug out if revision >= 3 and sync io is used, and warn if revision < 3 is used in the first place? hw/qxl.c | 27 +++ 1 file changed, 27 insertions(+) diff --git