Re: [Qemu-devel] [PATCH] hw/mcf5206: Fix buffer overflow for MBAR read / write

2012-09-10 Thread Aurelien Jarno
On Tue, Sep 04, 2012 at 07:37:39PM +0200, Stefan Weil wrote: > Report from smatch: > > mcf5206.c:384 m5206_mbar_readb(7) error: buffer overflow 'm5206_mbar_width' > 128 <= 128 > mcf5206.c:403 m5206_mbar_readw(8) error: buffer overflow 'm5206_mbar_width' > 128 <= 128 > mcf5206.c:427 m5206_mbar_re

Re: [Qemu-devel] [PATCH] hw/mcf5206: Fix buffer overflow for MBAR read / write

2012-09-04 Thread Peter Maydell
On 4 September 2012 19:16, Stefan Weil wrote: > Am 04.09.2012 20:12, schrieb Stefan Weil: >> Am 04.09.2012 19:57, schrieb Peter Maydell: >>> Checked against the data sheet -- last documented register is at >>> offset $1F0, so correcting the offset check rather than the array >>> length is the corr

Re: [Qemu-devel] [PATCH] hw/mcf5206: Fix buffer overflow for MBAR read / write

2012-09-04 Thread Stefan Weil
Am 04.09.2012 20:12, schrieb Stefan Weil: Am 04.09.2012 19:57, schrieb Peter Maydell: On 4 September 2012 18:37, Stefan Weil wrote: Report from smatch: mcf5206.c:384 m5206_mbar_readb(7) error: buffer overflow 'm5206_mbar_width' 128 <= 128 mcf5206.c:403 m5206_mbar_readw(8) error: buffer overf

Re: [Qemu-devel] [PATCH] hw/mcf5206: Fix buffer overflow for MBAR read / write

2012-09-04 Thread Stefan Weil
Am 04.09.2012 19:57, schrieb Peter Maydell: On 4 September 2012 18:37, Stefan Weil wrote: Report from smatch: mcf5206.c:384 m5206_mbar_readb(7) error: buffer overflow 'm5206_mbar_width' 128 <= 128 mcf5206.c:403 m5206_mbar_readw(8) error: buffer overflow 'm5206_mbar_width' 128 <= 128 mcf5206.

Re: [Qemu-devel] [PATCH] hw/mcf5206: Fix buffer overflow for MBAR read / write

2012-09-04 Thread Peter Maydell
On 4 September 2012 18:37, Stefan Weil wrote: > Report from smatch: > > mcf5206.c:384 m5206_mbar_readb(7) error: buffer overflow 'm5206_mbar_width' > 128 <= 128 > mcf5206.c:403 m5206_mbar_readw(8) error: buffer overflow 'm5206_mbar_width' > 128 <= 128 > mcf5206.c:427 m5206_mbar_readl(8) error: b

[Qemu-devel] [PATCH] hw/mcf5206: Fix buffer overflow for MBAR read / write

2012-09-04 Thread Stefan Weil
Report from smatch: mcf5206.c:384 m5206_mbar_readb(7) error: buffer overflow 'm5206_mbar_width' 128 <= 128 mcf5206.c:403 m5206_mbar_readw(8) error: buffer overflow 'm5206_mbar_width' 128 <= 128 mcf5206.c:427 m5206_mbar_readl(8) error: buffer overflow 'm5206_mbar_width' 128 <= 128 mcf5206.c:451