Re: [Qemu-devel] [PATCH] hw/machine: Remove the Zero check of nb_numa_nodes for numa_complete_configuration() follow-up

2018-07-10 Thread Eduardo Habkost
On Tue, Jul 10, 2018 at 06:51:29PM +0800, Dou Liyang wrote: > This Commit 7747abf11487 misses the curly brackets. Follow Igor's and > Eduardo's suggestion, > > Add a follow-up patch for it. > > Signed-off-by: Dou Liyang I'm queueing this for 3.1, but the subject line didn't make sense (this pa

Re: [Qemu-devel] [PATCH] hw/machine: Remove the Zero check of nb_numa_nodes for numa_complete_configuration() follow-up

2018-07-10 Thread Igor Mammedov
On Tue, 10 Jul 2018 18:51:29 +0800 Dou Liyang wrote: > This Commit 7747abf11487 misses the curly brackets. Follow Igor's and > Eduardo's suggestion, > > Add a follow-up patch for it. > > Signed-off-by: Dou Liyang > --- > hw/core/machine.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletio

[Qemu-devel] [PATCH] hw/machine: Remove the Zero check of nb_numa_nodes for numa_complete_configuration() follow-up

2018-07-10 Thread Dou Liyang
This Commit 7747abf11487 misses the curly brackets. Follow Igor's and Eduardo's suggestion, Add a follow-up patch for it. Signed-off-by: Dou Liyang --- hw/core/machine.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/core/machine.c b/hw/core/machine.c index a9aeb22f03

Re: [Qemu-devel] [PATCH] hw/machine: Remove the Zero check of nb_numa_nodes

2018-07-04 Thread Dou Liyang
At 07/04/2018 07:52 PM, Dou Liyang wrote: Commit 7a3099fc9c5c("numa: postpone options post-processing till machine_run_board_init()") broke the commit 7b8be49d36fc("NUMA: Enable adding NUMA node implicitly"). The machine_run_board_init() doesn't do NUMA setup if nb_numa_nodes=0. Due to the

[Qemu-devel] [PATCH] hw/machine: Remove the Zero check of nb_numa_nodes

2018-07-04 Thread Dou Liyang
Commit 7a3099fc9c5c("numa: postpone options post-processing till machine_run_board_init()") broke the commit 7b8be49d36fc("NUMA: Enable adding NUMA node implicitly"). The machine_run_board_init() doesn't do NUMA setup if nb_numa_nodes=0. Due to the NUMA setup will also check the value of nb_numa