On 12 January 2012 10:16, Mitsyanko Igor wrote:
> Hi Peter, I have a small question. Wouldn't it be better to use uint32_t for
> variables that actually have positive values only? That would make code
> easier to understand.
The idea is to do a straightforward and easy to review conversion.
Switc
On 12/20/2011 02:01 AM, Peter Maydell wrote:
Implement save/load for the LAN9118.
Signed-off-by: Peter Maydell
---
Does anybody have a nicer solution to the "can't put an enum in a
VMStateDescription" problem?
hw/lan9118.c | 126 +++---
1
Am 19.12.2011 23:01, schrieb Peter Maydell:
> Implement save/load for the LAN9118.
>
> Signed-off-by: Peter Maydell
Reviewed-by: Andreas Färber
The type conversions are okay. The VMState fields look sane on a short
look, didn't check for completeness though.
Andreas
> ---
> Does anybody have
On consideration, unless somebody wishes to:
(a) commit this
(b) object
I'm going to put it in the next arm-devs pullreq I do. This is
reasonably justifiable since the only boards using lan9118 are the
ARM realview and vexpress devboard models.
-- PMM
On 10 January 2012 16:55, Peter Maydell w
Ping^2 (slightly early but there's another patch on list which will
conflict so we ought to get one committed at least)
thanks
-- PMM
On 4 January 2012 10:41, Peter Maydell wrote:
> Ping?
>
> -- PMM
>
> On 19 December 2011 22:01, Peter Maydell wrote:
>> Implement save/load for the LAN9118.
>>
>
Ping?
-- PMM
On 19 December 2011 22:01, Peter Maydell wrote:
> Implement save/load for the LAN9118.
>
> Signed-off-by: Peter Maydell
> ---
> Does anybody have a nicer solution to the "can't put an enum in a
> VMStateDescription" problem?
>
> hw/lan9118.c | 126
> +
Implement save/load for the LAN9118.
Signed-off-by: Peter Maydell
---
Does anybody have a nicer solution to the "can't put an enum in a
VMStateDescription" problem?
hw/lan9118.c | 126 +++---
1 files changed, 103 insertions(+), 23 deletions(-