Re: [Qemu-devel] [PATCH] hw/i386: fix nvdimm check error path

2017-06-19 Thread Stefan Hajnoczi
On Fri, Jun 16, 2017 at 05:03:48PM +0300, Michael S. Tsirkin wrote: > On Fri, Jun 16, 2017 at 02:19:56PM +0100, Stefan Hajnoczi wrote: > > On Fri, Jun 09, 2017 at 04:16:15PM +0100, Stefan Hajnoczi wrote: > > > Commit e987c37aee1752177906847630d32477da57e705 ("hw/i386: check if > > > nvdimm is enabl

Re: [Qemu-devel] [PATCH] hw/i386: fix nvdimm check error path

2017-06-16 Thread Michael S. Tsirkin
On Fri, Jun 16, 2017 at 02:19:56PM +0100, Stefan Hajnoczi wrote: > On Fri, Jun 09, 2017 at 04:16:15PM +0100, Stefan Hajnoczi wrote: > > Commit e987c37aee1752177906847630d32477da57e705 ("hw/i386: check if > > nvdimm is enabled before plugging") introduced a check to reject nvdimm > > hotplug if -mac

Re: [Qemu-devel] [PATCH] hw/i386: fix nvdimm check error path

2017-06-16 Thread Stefan Hajnoczi
On Fri, Jun 09, 2017 at 04:16:15PM +0100, Stefan Hajnoczi wrote: > Commit e987c37aee1752177906847630d32477da57e705 ("hw/i386: check if > nvdimm is enabled before plugging") introduced a check to reject nvdimm > hotplug if -machine pc,nvdimm=on was not given. > > This check executes after pc_dimm_m

Re: [Qemu-devel] [PATCH] hw/i386: fix nvdimm check error path

2017-06-11 Thread Haozhong Zhang
On 06/09/17 16:16 +0100, Stefan Hajnoczi wrote: > Commit e987c37aee1752177906847630d32477da57e705 ("hw/i386: check if > nvdimm is enabled before plugging") introduced a check to reject nvdimm > hotplug if -machine pc,nvdimm=on was not given. > > This check executes after pc_dimm_memory_plug() has

Re: [Qemu-devel] [PATCH] hw/i386: fix nvdimm check error path

2017-06-09 Thread Eduardo Habkost
On Fri, Jun 09, 2017 at 04:16:15PM +0100, Stefan Hajnoczi wrote: > Commit e987c37aee1752177906847630d32477da57e705 ("hw/i386: check if > nvdimm is enabled before plugging") introduced a check to reject nvdimm > hotplug if -machine pc,nvdimm=on was not given. > > This check executes after pc_dimm_m

[Qemu-devel] [PATCH] hw/i386: fix nvdimm check error path

2017-06-09 Thread Stefan Hajnoczi
Commit e987c37aee1752177906847630d32477da57e705 ("hw/i386: check if nvdimm is enabled before plugging") introduced a check to reject nvdimm hotplug if -machine pc,nvdimm=on was not given. This check executes after pc_dimm_memory_plug() has already completed and does not reverse the effect of this